[Console] replaced fgets by stream_get_line in DialogHelper

fabpot · fabpot · commit 3a5d508766f0 · 2011-07-07T09:41:45.000+02:00
Problem with fgets is that false means two things: an error or the end of the stream.
That's ok for STDIN, but it becomes a problem when using another stream (in a unit test for instance).
diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php
@@ -35,7 +35,7 @@ public function ask(OutputInterface $output, $question, $default = null)
     {
         $output->write($question);
 
-        if (false === $ret = fgets(null === $this->inputStream ? STDIN : $this->inputStream)) {
+        if (false === stream_get_line(null === $this->inputStream ? STDIN : $this->inputStream, 4096, "\n")) {
             throw new \Exception('Aborted');
         }
         $ret = trim($ret);

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function ask(OutputInterface $output, $question, $default = null)`
`35`	`35`	`{`
`36`	`36`	`$output->write($question);`
`37`	`37`
`38`		`- if (false === $ret = fgets(null === $this->inputStream ? STDIN : $this->inputStream)) {`
`38`	`+ if (false === stream_get_line(null === $this->inputStream ? STDIN : $this->inputStream, 4096, "\n")) {`
`39`	`39`	`throw new \Exception('Aborted');`
`40`	`40`	`}`
`41`	`41`	`$ret = trim($ret);`