10000 bug #36447 Remove return type for Twig function workflow_metadata() (… · symfony/symfony@39a7ee1 · GitHub
[go: up one dir, main page]

Skip to content

Commit 39a7ee1

Browse files
committed
bug #36447 Remove return type for Twig function workflow_metadata() (gisostallenberg)
This PR was merged into the 4.4 branch. Discussion ---------- Remove return type for Twig function workflow_metadata() Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36391 | License | MIT | Doc PR | n/a The workflow metadata store can contain not only strings, but setting nested metadata results in an error when workflow_metadata() is used in Twig. Also see #36391 Commits ------- 55664c5 Remove return type for Twig function workflow_metadata()
2 parents efb0dee + 55664c5 commit 39a7ee1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)
117117
* Use a string (the place name) to get place metadata
118118
* Use a Transition instance to get transition metadata
119119
*/
120-
public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string
120+
public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)
121121
{
122122
return $this
123123
->workflowRegistry

0 commit comments

Comments
 (0)
0