bug #36447 Remove return type for Twig function workflow_metadata() (gisostallenberg)

fabpot · fabpot · commit 39a7ee1a61b3 · 2020-04-15T11:12:33.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- Remove return type for Twig function workflow_metadata() Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36391 | License | MIT | Doc PR | n/a The workflow metadata store can contain not only strings, but setting nested metadata results in an error when workflow_metadata() is used in Twig. Also see #36391 Commits ------- 55664c5 Remove return type for Twig function workflow_metadata()
diff --git a/src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php b/src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php
@@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)
      *                                                Use a string (the place name) to get place metadata
      *                                                Use a Transition instance to get transition metadata
      */
-    public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string
+    public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)
     {
         return $this
             ->workflowRegistry

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)`
`117`	`117`	`* Use a string (the place name) to get place metadata`
`118`	`118`	`* Use a Transition instance to get transition metadata`
`119`	`119`	`*/`
`120`		`- public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string`
	`120`	`+ public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)`
`121`	`121`	`{`
`122`	`122`	`return $this`
`123`	`123`	`->workflowRegistry`