Tweaks thanks to Wouter

weaverryan · weaverryan · commit 396a1622dc69 · 2015-09-20T19:51:09.000-04:00
diff --git a/src/Symfony/Component/Security/Guard/Provider/GuardAuthenticationProvider.php b/src/Symfony/Component/Security/Guard/Provider/GuardAuthenticationProvider.php
@@ -114,24 +114,21 @@ private function authenticateViaGuard(GuardAuthenticatorInterface $guardAuthenti
 
         if (!$user instanceof UserInterface) {
             throw new \UnexpectedValueException(sprintf(
-                'The %s::getUser method must return a UserInterface. You returned %s.',
+                'The %s::getUser() method must return a UserInterface. You returned %s.',
                 get_class($guardAuthenticator),
                 is_object($user) ? get_class($user) : gettype($user)
             ));
         }
 
-        // check the preAuth UserChecker
         $this->userChecker->checkPreAuth($user);
-        // check the credentials
         $guardAuthenticator->checkCredentials($token->getCredentials(), $user);
-        // check the postAuth UserChecker
         $this->userChecker->checkPostAuth($user);
 
         // turn the UserInterface into a TokenInterface
         $authenticatedToken = $guardAuthenticator->createAuthenticatedToken($user, $this->providerKey);
         if (!$authenticatedToken instanceof TokenInterface) {
             throw new \UnexpectedValueException(sprintf(
-                'The %s::createAuthenticatedToken method must return a TokenInterface. You returned %s.',
+                'The %s::createAuthenticatedToken() method must return a TokenInterface. You returned %s.',
                 get_class($guardAuthenticator),
                 is_object($authenticatedToken) ? get_class($authenticatedToken) : gettype($authenticatedToken)
             ));
diff --git a/src/Symfony/Component/Security/Guard/Token/PreAuthenticationGuardToken.php b/src/Symfony/Component/Security/Guard/Token/PreAuthenticationGuardToken.php
@@ -60,6 +60,6 @@ public function getCredentials()
 
     public function setAuthenticated($authenticated)
     {
-        throw new \LogicException('The PreAuthenticationGuardToken is *always* not authenticated.');
+        throw new \LogicException('The PreAuthenticationGuardToken is *never* authenticated.');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,6 @@ public function getCredentials()`
`60`	`60`
`61`	`61`	`public function setAuthenticated($authenticated)`
`62`	`62`	`{`
`63`		`- throw new \LogicException('The PreAuthenticationGuardToken is always not authenticated.');`
	`63`	`+ throw new \LogicException('The PreAuthenticationGuardToken is never authenticated.');`
`64`	`64`	`}`
`65`	`65`	`}`