8000 minor #49000 Fix Psalm errors (danepowell) · symfony/symfony@395eb9a · GitHub
[go: up one dir, main page]
Skip to content

Commit 395eb9a

Browse files
fabpotfabpot
committed
minor #49000 Fix Psalm errors (danepowell)
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- Fix Psalm errors | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | Not sure what you call a CI fix 🤷 | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Psalm runs frequently fail, such as #48981 Commits ------- 62dcacd Fix Psalm errors
2 parents 9574953 + 62dcacd commit 395eb9a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

‎.github/workflows/psalm.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,10 @@ jobs:
4949
git checkout composer.json
5050
git checkout -m ${{ github.base_ref }}
5151
52-
# to be removed when psalm adds support for intersection types
52+
# @todo intersection types are broken in Psalm
53+
# @see https://github.com/vimeo/psalm/issues/7520
5354
sed -i 's/Uuid&/Uuid|/' src/Symfony/Component/Uid/Factory/TimeBasedUuidFactory.php
55+
sed -i 's/Interface&/Interface|/' src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MigratingSessionHandler.php
5456
./vendor/bin/psalm.phar --set-baseline=.github/psalm/psalm.baseline.xml --no-progress
5557
git checkout -m FETCH_HEAD
5658

0 commit comments

Comments
 (0)
0