prevent failures around not existing TypeInfo classes

xabbuh · xabbuh · commit 386453ee77b6 · 2024-11-14T11:06:52.000+01:00
Having a getType() method on an extractor is not enough. Such a method may
exist to be forward-compatible with the TypeInfo component. We still must
not call it if the TypeInfo component is not installed to prevent running into
errors for not-defined classes when the TypeInfo component is not installed.
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -938,7 +938,7 @@ private function getType(string $currentClass, string $attribute): Type|array|nu
      */
     private function getPropertyType(string $className, string $property): Type|array|null
     {
-        if (method_exists($this->propertyTypeExtractor, 'getType')) {
+        if (class_exists(Type::class) && method_exists($this->propertyTypeExtractor, 'getType')) {
             return $this->propertyTypeExtractor->getType($className, $property);
         }
 
diff --git a/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php b/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php
@@ -175,7 +175,7 @@ public function loadClassMetadata(ClassMetadata $metadata): bool
      */
     private function getPropertyTypes(string $className, string $property): TypeInfoType|array|null
     {
-        if (method_exists($this->typeExtractor, 'getType')) {
+        if (class_exists(TypeInfoType::class) && method_exists($this->typeExtractor, 'getType')) {
             return $this->typeExtractor->getType($className, $property);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -938,7 +938,7 @@ private function getType(string $currentClass, string $attribute): Type\|array\|nu`
`938`	`938`	`*/`
`939`	`939`	`private function getPropertyType(string $className, string $property): Type\|array\|null`
`940`	`940`	`{`
`941`		`- if (method_exists($this->propertyTypeExtractor, 'getType')) {`
	`941`	`+ if (class_exists(Type::class) && method_exists($this->propertyTypeExtractor, 'getType')) {`
`942`	`942`	`return $this->propertyTypeExtractor->getType($className, $property);`
`943`	`943`	`}`
`944`	`944`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ public function loadClassMetadata(ClassMetadata $metadata): bool`
`175`	`175`	`*/`
`176`	`176`	`private function getPropertyTypes(string $className, string $property): TypeInfoType\|array\|null`
`177`	`177`	`{`
`178`		`- if (method_exists($this->typeExtractor, 'getType')) {`
	`178`	`+ if (class_exists(TypeInfoType::class) && method_exists($this->typeExtractor, 'getType')) {`
`179`	`179`	`return $this->typeExtractor->getType($className, $property);`
`180`	`180`	`}`
`181`	`181`