bug #45053 [Console] use STDOUT/ERR in ConsoleOutput to save opening too many file descriptors (nicolas-grekas)

fabpot · fabpot · commit 383869635f56 · 2022-01-19T10:41:43.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Console] use STDOUT/ERR in ConsoleOutput to save opening too many file descriptors | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #44882 | License | MIT | Doc PR | - /cc @jtojnar can you please give this patch a try and report back? Commits ------- 6eaf9e6 [Console] use STDOUT/ERR in ConsoleOutput to save opening too many file descriptors
diff --git a/src/Symfony/Component/Console/Output/ConsoleOutput.php b/src/Symfony/Component/Console/Output/ConsoleOutput.php
@@ -153,14 +153,20 @@ private function openOutputStream()
             return fopen('php://output', 'w');
         }
 
-        return @fopen('php://stdout', 'w') ?: fopen('php://output', 'w');
+        // Use STDOUT when possible to prevent from opening too many file descriptors
+        return \defined('STDOUT') ? \STDOUT : (@fopen('php://stdout', 'w') ?: fopen('php://output', 'w'));
     }
 
     /**
      * @return resource
      */
     private function openErrorStream()
     {
-        return fopen($this->hasStderrSupport() ? 'php://stderr' : 'php://output', 'w');
+        if (!$this->hasStderrSupport()) {
+            return fopen('php://output', 'w');
+        }
+
+        // Use STDERR when possible to prevent from opening too many file descriptors
+        return \defined('STDERR') ? \STDERR : (@fopen('php://stderr', 'w') ?: fopen('php://output', 'w'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -153,14 +153,20 @@ private function openOutputStream()`
`153`	`153`	`return fopen('php://output', 'w');`
`154`	`154`	`}`
`155`	`155`
`156`		`- return @fopen('php://stdout', 'w') ?: fopen('php://output', 'w');`
	`156`	`+ // Use STDOUT when possible to prevent from opening too many file descriptors`
	`157`	`+ return \defined('STDOUT') ? \STDOUT : (@fopen('php://stdout', 'w') ?: fopen('php://output', 'w'));`
`157`	`158`	`}`
`158`	`159`
`159`	`160`	`/**`
`160`	`161`	`* @return resource`
`161`	`162`	`*/`
`162`	`163`	`private function openErrorStream()`
`163`	`164`	`{`
`164`		`- return fopen($this->hasStderrSupport() ? 'php://stderr' : 'php://output', 'w');`
	`165`	`+ if (!$this->hasStderrSupport()) {`
	`166`	`+ return fopen('php://output', 'w');`
	`167`	`+ }`
	`168`	`+`
	`169`	`+ // Use STDERR when possible to prevent from opening too many file descriptors`
	`170`	`+ return \defined('STDERR') ? \STDERR : (@fopen('php://stderr', 'w') ?: fopen('php://output', 'w'));`
`165`	`171`	`}`
`166`	`172`	`}`