bug #54254 [HttpKernel] Fix creating ReflectionMethod with only one argument (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 37e436f70a25 · 2024-03-12T15:24:32.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Fix creating `ReflectionMethod` with only one argument | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Part of #54180 | License | MIT Remaining PHP 8.4 deprecations on 6.4 Commits ------- f32d633 [HttpKernel] Fix creating `ReflectionMethod` with only one argument
diff --git a/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php b/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php
@@ -70,7 +70,7 @@ public function setController(callable $controller, ?array $attributes = null):
         if (\is_array($controller) && method_exists(...$controller)) {
             $this->controllerReflector = new \ReflectionMethod(...$controller);
         } elseif (\is_string($controller) && str_contains($controller, '::')) {
-            $this->controllerReflector = new \ReflectionMethod($controller);
+            $this->controllerReflector = new \ReflectionMethod(...explode('::', $controller, 2));
         } else {
             $this->controllerReflector = new \ReflectionFunction($controller(...));
         }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function setController(callable $controller, ?array $attributes = null):`
`70`	`70`	`if (\is_array($controller) && method_exists(...$controller)) {`
`71`	`71`	`$this->controllerReflector = new \ReflectionMethod(...$controller);`
`72`	`72`	`} elseif (\is_string($controller) && str_contains($controller, '::')) {`
`73`		`- $this->controllerReflector = new \ReflectionMethod($controller);`
	`73`	`+ $this->controllerReflector = new \ReflectionMethod(...explode('::', $controller, 2));`
`74`	`74`	`} else {`
`75`	`75`	`$this->controllerReflector = new \ReflectionFunction($controller(...));`
`76`	`76`	`}`