bug #46239 [Translation] Refresh local translations on PushCommand if the provider has domains (Florian-B)

chalasr · chalasr · commit 37b8077c02bb · 2022-05-06T14:57:59.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Translation] Refresh local translations on PushCommand if the provider has domains | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no Since #45171 it's possible to define targeted translation domains in configuration. On `translation:push` without `--domains` option the command should read our configuration in order build local translations list. If the domain is only define in the configuration we need to refresh the local translations list to prevent full update of Provider (push all domains without filtering). I think we should add a test but I failed to do it properly. Commits ------- 8b0f7eb [Translation] Refresh local translations if the provider has domains
diff --git a/src/Symfony/Component/Translation/Command/TranslationPushCommand.php b/src/Symfony/Component/Translation/Command/TranslationPushCommand.php
@@ -131,16 +131,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $force = $input->getOption('force');
         $deleteMissing = $input->getOption('delete-missing');
 
+        if (!$domains && $provider instanceof FilteringProvider) {
+            $domains = $provider->getDomains();
+        }
+
+        // Reading local translations must be done after retrieving the domains from the provider
+        // in order to manage only translations from configured domains
         $localTranslations = $this->readLocalTranslations($locales, $domains, $this->transPaths);
 
         if (!$domains) {
-            if ($provider instanceof FilteringProvider) {
-                $domains = $provider->getDomains();
-            }
-
-            if (!$domains) {
-                $domains = $this->getDomainsFromTranslatorBag($localTranslations);
-            }
+            $domains = $this->getDomainsFromTranslatorBag($localTranslations);
         }
 
         if (!$deleteMissing && $force) {
