minor #30764 [Messenger] Changing message handling log levels to higher levels (weaverryan)

sroze · sroze · commit 37b616fefbd2 · 2019-03-29T21:53:56.000+07:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Changing message handling log levels to higher levels | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | not needed Update log levels so that the user can configure the logger to be notified of errors. This was really an oversight when I originally added the logging. Cheers! Commits ------- 9153c48 Changing message handling log levels to higher levels
diff --git a/src/Symfony/Component/Messenger/Worker.php b/src/Symfony/Component/Messenger/Worker.php
@@ -99,7 +99,7 @@ public function run()
 
                     $retryCount = $this->getRetryCount($envelope) + 1;
                     if (null !== $this->logger) {
-                        $this->logger->info('Retrying {class} - retry #{retryCount}.', $context + ['retryCount' => $retryCount, 'error' => $throwable]);
+                        $this->logger->error('Retrying {class} - retry #{retryCount}.', $context + ['retryCount' => $retryCount, 'error' => $throwable]);
                     }
 
                     // add the delay and retry stamp info + remove ReceivedStamp
@@ -113,7 +113,7 @@ public function run()
                     $this->receiver->ack($envelope);
                 } else {
                     if (null !== $this->logger) {
-                        $this->logger->info('Rejecting {class} (removing from transport).', $context + ['error' => $throwable]);
+                        $this->logger->critical('Rejecting {class} (removing from transport).', $context + ['error' => $throwable]);
                     }
 
                     $this->receiver->reject($envelope);

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public function run()`
`99`	`99`
`100`	`100`	`$retryCount = $this->getRetryCount($envelope) + 1;`
`101`	`101`	`if (null !== $this->logger) {`
`102`		`- $this->logger->info('Retrying {class} - retry #{retryCount}.', $context + ['retryCount' => $retryCount, 'error' => $throwable]);`
	`102`	`+ $this->logger->error('Retrying {class} - retry #{retryCount}.', $context + ['retryCount' => $retryCount, 'error' => $throwable]);`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`// add the delay and retry stamp info + remove ReceivedStamp`
`@@ -113,7 +113,7 @@ public function run()`
`113`	`113`	`$this->receiver->ack($envelope);`
`114`	`114`	`} else {`
`115`	`115`	`if (null !== $this->logger) {`
`116`		`- $this->logger->info('Rejecting {class} (removing from transport).', $context + ['error' => $throwable]);`
	`116`	`+ $this->logger->critical('Rejecting {class} (removing from transport).', $context + ['error' => $throwable]);`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`$this->receiver->reject($envelope);`