8000 fail when detecting risky tests · symfony/symfony@3792ee6 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3792ee6

Browse files
committed
fail when detecting risky tests
1 parent f478161 commit 3792ee6

File tree

49 files changed

+98
-6
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+98
-6
lines changed

phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bridge/Doctrine/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bridge/Monolog/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bridge/PhpUnit/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bridge/ProxyManager/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bridge/Twig/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"require-dev": {
2323
"symfony/asset": "~2.7",
2424
"symfony/finder": "~2.3",
25-
"symfony/form": "~2.7.25|^2.8.18",
25+
"symfony/form": "~2.7.26|^2.8.19",
2626
"symfony/http-kernel": "~2.3",
2727
"symfony/intl": "~2.3",
2828
"symfony/routing": "~2.2",

src/Symfony/Bridge/Twig/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="fals 10000 e"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bundle/DebugBundle/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bundle/FrameworkBundle/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"symfony/dom-crawler": "^2.0.5",
4141
"symfony/intl": "~2.3",
4242
"symfony/security": "~2.6",
43-
"symfony/form": "~2.7.25|^2.8.18",
43+
"symfony/form": "~2.7.26|^2.8.19",
4444
"symfony/class-loader": "~2.1",
4545
"symfony/expression-language": "~2.6",
4646
"symfony/process": "^2.0.5",

src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bundle/TwigBundle/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Asset/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/BrowserKit/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/ClassLoader/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Config/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Console/Tests/Helper/LegacyTableHelperTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ protected function tearDown()
3434
}
3535

3636
/**
37-
* @dataProvider testRenderProvider
37+
* @dataProvider renderProvider
3838
*/
3939
public function testRender($headers, $rows, $layout, $expected)
4040
{
@@ -50,7 +50,7 @@ public function testRender($headers, $rows, $layout, $expected)
5050
}
5151

5252
/**
53-
* @dataProvider testRenderProvider
53+
* @dataProvider renderProvider
5454
*/
5555
public function testRenderAddRows($headers, $rows, $layout, $expected)
5656
{
@@ -66,7 +66,7 @@ public function testRenderAddRows($headers, $rows, $layout, $expected)
6666
}
6767

6868
/**
69-
* @dataProvider testRenderProvider
69+
* @dataProvider renderProvider
7070
*/
7171
public function testRenderAddRowsOneByOne($headers, $rows, $layout, $expected)
7272
{
@@ -83,7 +83,7 @@ public function testRenderAddRowsOneByOne($headers, $rows, $layout, $expected)
8383
$this->assertEquals($expected, $this->getOutputContent($output));
8484
}
8585

86-
public function testRenderProvider()
86+
public function renderProvider()
8787
{
8888
$books = array(
8989
array('99921-58-10-7', 'Divine Comedy', 'Dante Alighieri'),

src/Symfony/Component/Console/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/CssSelector/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Debug/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/DependencyInjection/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/DomCrawler/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/EventDispatcher/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
stopOnFailure="false"
1111
syntaxCheck="false"
1212
bootstrap="vendor/autoload.php"
13+
failOnRisky="true"
14+
failOnWarning="true"
1315
>
1416
<php>
1517
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Filesystem/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Finder/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Form/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/HttpFoundation/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/HttpKernel/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Intl/Tests/Locale/LocaleTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ public function testSetDefault()
153153
public function testSetDefaultAcceptsEn()
154154
{
155155
$this->call('setDefault', 'en');
156+
157+
$this->assertSame('en', $this->call('getDefault'));
156158
}
157159

158160
protected function call($methodName)

src/Symfony/Component/Intl/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Locale/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/OptionsResolver/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Process/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/PropertyAccess/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Routing/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
backupGlobals="false"
66
colors="true"
77
bootstrap="vendor/autoload.php"
8+
failOnRisky="true"
9+
failOnWarning="true"
810
>
911
<php>
1012
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Security/Acl/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
stopOnFailure="false"
1111
syntaxCheck="false"
1212
bootstrap="vendor/autoload.php"
13+
failOnRisky="true"
14+
failOnWarning="true"
1315
>
1416
<php>
1517
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Security/Core/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
stopOnFailure="false"
1111
syntaxCheck="false"
1212
bootstrap="vendor/autoload.php"
13+
failOnRisky="true"
14+
failOnWarning="true"
1315
>
1416
<php>
1517
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Security/Csrf/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
stopOnFailure="false"
1111
syntaxCheck="false"
1212
bootstrap="vendor/autoload.php"
13+
failOnRisky="true"
14+
failOnWarning="true"
1315
>
1416
<php>
1517
<ini name="error_reporting" value="-1" />

src/Symfony/Component/Security/Http/phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
stopOnFailure="false"
1111
syntaxCheck="false"
1212
bootstrap="vendor/autoload.php"
13+
failOnRisky="true"
14+
failOnWarning="true"
1315
>
1416
<php>
1517
<ini name="error_reporting" value="-1" />

0 commit comments

Comments
 (0)
0