bug #39525 [VarDumper] dont hide any nodes until JS is proven to work (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 3741b064df15 · 2020-12-17T09:32:53.000+01:00
This PR was merged into the 5.2 branch. Discussion ---------- [VarDumper] dont hide any nodes until JS is proven to work | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39394 | License | MIT | Doc PR | - Replaces #39523 Commits ------- 42ad1ec [VarDumper] dont hide any nodes until JS is proven to work
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -171,6 +171,9 @@ protected function getDumpHeader()
         e.addEventListener(n, cb, false);
     };
 
+refStyle.innerHTML = 'pre.sf-dump .sf-dump-compact, .sf-dump-str-collapse .sf-dump-str-collapse, .sf-dump-str-expand .sf-dump-str-expand { display: none; }';
+(doc.documentElement.firstElementChild || doc.documentElement.children[0]).appendChild(refStyle);
+refStyle = doc.createElement('style');
 (doc.documentElement.firstElementChild || doc.documentElement.children[0]).appendChild(refStyle);
 
 if (!doc.addEventListener) {
@@ -665,9 +668,6 @@ function showCurrent(state)
 pre.sf-dump span {
     display: inline;
 }
-pre.sf-dump .sf-dump-compact {
-    display: none;
-}
 pre.sf-dump a {
     text-decoration: none;
     cursor: pointer;
@@ -699,12 +699,6 @@ function showCurrent(state)
     padding:0;
     background:none;
 }
-.sf-dump-str-collapse .sf-dump-str-collapse {
-    display: none;
-}
-.sf-dump-str-expand .sf-dump-str-expand {
-    display: none;
-}
 .sf-dump-public.sf-dump-highlight,
 .sf-dump-protected.sf-dump-highlight,
 .sf-dump-private.sf-dump-highlight,
