minor #31779 [Form] do not iterate twice on the extended types (Tobion)

nicolas-grekas · nicolas-grekas · commit 371dfc7f45a0 · 2019-06-01T08:55:32.000+02:00
This PR was merged into the 5.0-dev branch. Discussion ---------- [Form] do not iterate twice on the extended types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #...  | License | MIT | Doc PR | Simplification of #31703 Commits ------- 75179d3 [Form] do not iterate twice on the extended types
diff --git a/src/Symfony/Component/Form/AbstractExtension.php b/src/Symfony/Component/Form/AbstractExtension.php
@@ -175,12 +175,7 @@ private function initTypeExtensions()
                 throw new UnexpectedTypeException($extension, 'Symfony\Component\Form\FormTypeExtensionInterface');
             }
 
-            $extendedTypes = [];
             foreach ($extension::getExtendedTypes() as $extendedType) {
-                $extendedTypes[] = $extendedType;
-            }
-
-            foreach ($extendedTypes as $extendedType) {
                 $this->typeExtensions[$extendedType][] = $extension;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -175,12 +175,7 @@ private function initTypeExtensions()`
`175`	`175`	`throw new UnexpectedTypeException($extension, 'Symfony\Component\Form\FormTypeExtensionInterface');`
`176`	`176`	`}`
`177`	`177`
`178`		`- $extendedTypes = [];`
`179`	`178`	`foreach ($extension::getExtendedTypes() as $extendedType) {`
`180`		`- $extendedTypes[] = $extendedType;`
`181`		`- }`
`182`		`-`
`183`		`- foreach ($extendedTypes as $extendedType) {`
`184`	`179`	`$this->typeExtensions[$extendedType][] = $extension;`
`185`	`180`	`}`
`186`	`181`	`}`