Fixing some Coding Standards complaints by fabbot

chii0815 · chii0815 · commit 36b936ed7289 · 2025-01-13T17:56:02.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Matrix/Exception/UnsupportesMsgTypeByAPIException.php b/src/Symfony/Component/Notifier/Bridge/Matrix/Exception/UnsupportesMsgTypeByAPIException.php
@@ -18,6 +18,6 @@ class UnsupportesMsgTypeByAPIException extends LogicException
 {
     public function __construct(string $given)
     {
-        parent::__construct(\sprintf('Unsupported message type: "%s". Only %s are supported by Matrix Synapse Client-Server API v3', $given, implode(', ',MatrixTransport::SUPPORTED_MSG_TYPES_BY_API)));
+        parent::__construct(\sprintf('Unsupported message type: "%s". Only %s are supported by Matrix Synapse Client-Server API v3', $given, implode(', ', MatrixTransport::SUPPORTED_MSG_TYPES_BY_API)));
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Matrix/MatrixTransport.php b/src/Symfony/Component/Notifier/Bridge/Matrix/MatrixTransport.php
@@ -33,6 +33,7 @@ final class MatrixTransport extends AbstractTransport
 {
     // not all Message Types are supported by Symfony API
     public const SUPPORTED_MSG_TYPES_BY_API = ['m.text', 'm.emote', 'm.notice', 'm.image', 'm.file', 'm.audio', 'm.video', 'm.key.verification'];
+
     public function __construct(
         #[\SensitiveParameter] private string $accessToken,
         private bool $ssl,
@@ -68,7 +69,7 @@ protected function doSend(MessageInterface $message): SentMessage
         $options['msgtype'] = $options['msgtype'] ?? 'm.text';
 
         // check if msgtype is supported by API
-        if (!in_array($options['msgtype'], self::SUPPORTED_MSG_TYPES_BY_API, true)) {
+        if (!\in_array($options['msgtype'], self::SUPPORTED_MSG_TYPES_BY_API, true)) {
             throw new UnsupportesMsgTypeByAPIException($options['msgtype']);
         }
 
@@ -137,7 +138,7 @@ private function createPrivateChannel(
     private function getDirectMessageChannel(
         string $recipientId,
     ): ?string {
-        $response = $this->getAccountData($this->getWhoami()['user_id'],'m.direct');
+        $response = $this->getAccountData($this->getWhoami()['user_id'], 'm.direct');
         if (!isset($response[$recipientId])) {
             $roomid = $this->createPrivateChannel($recipientId)['room_id'];
             $response[$recipientId] = [$roomid];
@@ -161,7 +162,7 @@ private function updateAccountData(
             options: [
                 'json' => $data,
             ]);
-        if($response->toArray()!== []) {
+        if ([] !== $response->toArray()) {
             throw new TransportException('Unable to update account data.', $response);
         }
     }
@@ -219,7 +220,7 @@ protected function connect(
             throw new TransportException('Could not reach the Matrix server.', $response, 0, $e);
         }
 
-        if (in_array($statusCode,[400,403,405])) {
+        if (\in_array($statusCode, [400,403,405])) {
             $result = $response->toArray(false);
             throw new TransportException(\sprintf('Error: Matrix responded with "%s (%s)"', $result['error'], $result['errcode']), $response);
         }
diff --git a/src/Symfony/Component/Notifier/Bridge/Matrix/Tests/MatrixTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Matrix/Tests/MatrixTransportTest.php
@@ -58,5 +58,4 @@ public function testUnsupportedMsgType(){
         $this->expectException(UnsupportesMsgTypeByAPIException::class);
         $transport->send(new ChatMessage('Hello!', new MatrixOptions(['recipient_id' => '@user:matrix.io', 'msgtype' => 'm.anything'])));
     }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,6 @@ class UnsupportesMsgTypeByAPIException extends LogicException`
`18`	`18`	`{`
`19`	`19`	`public function __construct(string $given)`
`20`	`20`	`{`
`21`		`- parent::__construct(\sprintf('Unsupported message type: "%s". Only %s are supported by Matrix Synapse Client-Server API v3', $given, implode(', ',MatrixTransport::SUPPORTED_MSG_TYPES_BY_API)));`
	`21`	`+ parent::__construct(\sprintf('Unsupported message type: "%s". Only %s are supported by Matrix Synapse Client-Server API v3', $given, implode(', ', MatrixTransport::SUPPORTED_MSG_TYPES_BY_API)));`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,5 +58,4 @@ public function testUnsupportedMsgType(){`
`58`	`58`	`$this->expectException(UnsupportesMsgTypeByAPIException::class);`
`59`	`59`	`$transport->send(new ChatMessage('Hello!', new MatrixOptions(['recipient_id' => '@user:matrix.io', 'msgtype' => 'm.anything'])));`
`60`	`60`	`}`
`61`		`-`
`62`	`61`	`}`