8000 minor #57714 [HttpFoundation] Add tests for uncovered sections (alexa… · symfony/symfony@3621f80 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3621f80

Browse files
nicolas-grekasnicolas-grekas
committed
minor #57714 [HttpFoundation] Add tests for uncovered sections (alexandre-daubois)
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] Add tests for uncovered sections | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- d9fa800 [HttpFoundation] Add tests for uncovered sections
2 parents c0929d8 + d9fa800 commit 3621f80

File tree

2 files changed

+47
-0
lines changed

2 files changed

+47
-0
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/InputBagTest.php‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,22 @@ public function testFilterArrayWithoutArrayFlagIsDeprecated()
9898
$this->expectDeprecation('Since symfony/http-foundation 5.1: Filtering an array value with "Symfony\Component\HttpFoundation\InputBag::filter()" without passing the FILTER_REQUIRE_ARRAY or FILTER_FORCE_ARRAY flag is deprecated');
9999
$bag->filter('foo', \FILTER_VALIDATE_INT);
100100
}
101+
102+
public function testAdd()
103+
{
104+
$bag = new InputBag(['foo' => 'bar']);
105+
$bag->add(['baz' => 'qux']);
106+
107+
$this->assertSame('bar', $bag->get('foo'), '->add() does not remove existing parameters');
108+
$this->assertSame('qux', $bag->get('baz'), '->add() adds new parameters');
109+
}
110+
111+
public function testReplace()
112+
{
113+
$bag = new InputBag(['foo' => 'bar']);
114+
$bag->replace(['baz' => 'qux']);
115+
116+
$this->assertNull($bag->get('foo'), '->replace() removes existing parameters');
117+
$this->assertSame('qux', $bag->get('baz'), '->replace() adds new parameters');
118+
}
101119
}

‎src/Symfony/Component/HttpFoundation/Tests/RateLimiter/AbstractRequestRateLimiterTest.php‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use PHPUnit\Framework\TestCase;
1515
use Symfony\Component\HttpFoundation\Request;
1616
use Symfony\Component\RateLimiter\LimiterInterface;
17+
use Symfony\Component\RateLimiter\Policy\NoLimiter;
1718
use Symfony\Component\RateLimiter\RateLimit;
1819

1920
class AbstractRequestRateLimiterTest extends TestCase
@@ -33,6 +34,34 @@ public function testConsume(array $rateLimits, ?RateLimit $expected)
3334
$this->assertSame($expected, $rateLimiter->consume(new Request()));
3435
}
3536

37+
public function testConsumeWithoutLimiterAddsSpecialNoLimiter()
38+
{
39+
$rateLimiter = new MockAbstractRequestRateLimiter([]);
40+
41+
try {
42+
$this->assertSame(\PHP_INT_MAX, $rateLimiter->consume(new Request())->getLimit());
43+
} catch (\TypeError $error) {
44+
if (str_contains($error->getMessage(), 'RateLimit::__construct(): Argument #1 ($availableTokens) must be of type int, float given')) {
45+
$this->markTestSkipped('This test cannot be run on a version of the RateLimiter component that uses \INF instead of \PHP_INT_MAX in NoLimiter.');
46+
}
47+
48+
throw $error;
49+
}
50+
}
51+
52+
public function testResetLimiters()
53+
{
54+
$rateLimiter = new MockAbstractRequestRateLimiter([
55+
$limiter1 = $this->createMock(LimiterInterface::class),
56+
$limiter2 = $this->createMock(LimiterInterface::class),
57+
]);
58+
59+
$limiter1->expects($this->once())->method('reset');
60+
$limiter2->expects($this->once())->method('reset');
61+
62+
$rateLimiter->reset(new Request());
63+
}
64+
3665
public static function provideRateLimits()
3766
{
3867
$now = new \DateTimeImmutable();

0 commit comments

Comments
 (0)
0