bug #50487 [VarDumper] Use documentElement instead of body for JS flag

ohader · ohader · commit 35f724b23f56 · 2023-05-31T10:21:43.000+02:00
Using `document.documentElement` allows to use the dumper outside of a `<html><body>...</body></html>` scenario. Fixes: #50487
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -163,8 +163,8 @@ protected function getDumpHeader()
 <script>
 Sfdump = window.Sfdump || (function (doc) {
 
-if (doc.body instanceof HTMLElement) {
-    doc.body.classList.add('sf-js-enabled');
+if (doc.documentElement) {
+    doc.documentElement.classList.add('sf-js-enabled');
 }
 
 var rxEsc = /([.*+?^${}()|\[\]\/\\])/g,

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ protected function getDumpHeader()`
`163`	`163`	`<script>`
`164`	`164`	`Sfdump = window.Sfdump \|\| (function (doc) {`
`165`	`165`
`166`		`-if (doc.body instanceof HTMLElement) {`
`167`		`- doc.body.classList.add('sf-js-enabled');`
	`166`	`+if (doc.documentElement) {`
	`167`	`+ doc.documentElement.classList.add('sf-js-enabled');`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`var rxEsc = /([.*+?^${}()\|\[\]\/\\])/g,`