8000 [Notifier] Remove deprecation in slack-notifier · symfony/symfony@3566574 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3566574

Browse files
jschaedljschaedl
committed
[Notifier] Remove deprecation in slack-notifier
1 parent 68563ec commit 3566574

File tree

4 files changed

+10
-22
lines changed

4 files changed

+10
-22
lines changed

‎UPGRADE-6.0.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,11 @@ Monolog
151151
* The `$actionLevel` constructor argument of `Symfony\Bridge\Monolog\Handler\FingersCrossed\NotFoundActivationStrategy` has been replaced by the `$inner` one which expects an ActivationStrategyInterface to decorate instead. `Symfony\Bridge\Monolog\Handler\FingersCrossed\NotFoundActivationStrategy` is now final.
152152
* The `$actionLevel` constructor argument of `Symfony\Bridge\Monolog\Handler\FingersCrossed\HttpCodeActivationStrategy` has been replaced by the `$inner` one which expects an ActivationStrategyInterface to decorate instead. `Symfony\Bridge\Monolog\Handler\FingersCros 8000 sed\HttpCodeActivationStrategy` is now final.
153153

154+
Notifier
155+
--------
156+
157+
* symfony/slack-notifier: Removed `SlackOptions::channel()`, use `SlackOptions::recipient()` instead.
158+
154159
OptionsResolver
155160
---------------
156161

‎src/Symfony/Component/Notifier/Bridge/Slack/CHANGELOG.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
6.0
5+
---
6+
7+
* Removed `SlackOptions::channel()`, use `SlackOptions::recipient()` instead.
8+
49
5.3
510
---
611

‎src/Symfony/Component/Notifier/Bridge/Slack/SlackOptions.php‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,6 @@ public function getRecipientId(): ?string
5858
return $this->options['recipient_id'] ?? null;
5959
}
6060

61-
/**
62-
* @return $this
63-
*
64-
* @deprecated since Symfony 5.1, use recipient() instead.
65-
*/
66-
public function channel(string $channel): self
67-
{
68-
trigger_deprecation('symfony/slack-notifier', '5.1', 'The "%s()" method is deprecated, use "recipient()" instead.', __METHOD__);
69-
70-
return $this;
71-
}
72-
7361
/**
7462
* @param string $id The hook id (anything after https://hooks.slack.com/services/)
7563
*

‎src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackOptionsTest.php‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,6 @@ public function testSetBlock()
122122
$this->assertSame([['type' => 'divider']], $options->toArray()['blocks']);
123123
}
124124

125-
/**
126-
* @group legacy
127-
*/
128-
public function testChannelMethodRaisesDeprecation()
129-
{
130-
$this->expectDeprecation('Since symfony/slack-notifier 5.1: The "Symfony\Component\Notifier\Bridge\Slack\SlackOptions::channel()" method is deprecated, use "recipient()" instead.');
131-
132-
(new SlackOptions())->channel('channel');
133-
}
134-
135125
/**
136126
* @dataProvider fromNotificationProvider
137127
*/

0 commit comments

Comments
 (0)
0