feature #51848 [Messenger] Resend failed retries back to failure transport (ro0NL)

fabpot · fabpot · commit 34a93efd23e8 · 2023-10-05T08:02:10.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] Resend failed retries back to failure transport | Q | A | ------------- | --- | Branch? | 6.4 / 5.4 | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | Fix #51815 | License | MIT i want to argue this is a bugfix :) i can confirm with this fix, you can indefinitely retry failures, till they succeed, are deleted manually, or are handled explicitly by other means. What should NOT happen is systems implicitly rejecting/acking messages without any confirmation whatsoever. cc `@fabpot`, `@weaverryan` Commits ------- 53a4a37 [Messenger] Resend failed retries back to failure transport
diff --git a/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php b/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php
@@ -52,11 +52,6 @@ public function onMessageFailed(WorkerMessageFailedEvent $event)
 
         $envelope = $event->getEnvelope();
 
-        // avoid re-sending to the failed sender
-        if (null !== $envelope->last(SentToFailureTransportStamp::class)) {
-            return;
-        }
-
         $envelope = $envelope->with(
             new SentToFailureTransportStamp($event->getReceiverName()),
             new DelayStamp(0),
