bug #24971 [FrameworkBundle] Empty event dispatcher earlier in CacheClearCommand (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 3398c4b88138 · 2017-11-16T23:39:45.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Empty event dispatcher earlier in CacheClearCommand | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Once the cache folder is emptied, the event dispatcher cannot be used because service factories are gone. This currently fails very badly when an error is dispatched, but the error listeners are themselves failing to be loaded for this reason. Commits ------- a961392 [FrameworkBundle] Empty event dispatcher earlier in CacheClearCommand
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
@@ -111,6 +111,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $io->comment(sprintf('Clearing the cache for the <info>%s</info> environment with debug <info>%s</info>', $kernel->getEnvironment(), var_export($kernel->isDebug(), true)));
         $this->cacheClearer->clear($realCacheDir);
 
+        // The current event dispatcher is stale, let's not use it anymore
+        $this->getApplication()->setDispatcher(new EventDispatcher());
+
         if ($input->getOption('no-warmup')) {
             $this->filesystem->rename($realCacheDir, $oldCacheDir);
         } else {
@@ -129,9 +132,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $this->filesystem->remove($oldCacheDir);
 
-        // The current event dispatcher is stale, let's not use it anymore
-        $this->getApplication()->setDispatcher(new EventDispatcher());
-
         if ($output->isVerbose()) {
             $io->comment('Finished');
         }
