NativeFileSession won't override the php.ini settings anymore

dlsniper · dlsniper · commit 314c16beff91 · 2012-08-15T23:37:50.000+03:00
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NativeFileSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NativeFileSessionHandler.php
@@ -33,6 +33,13 @@ class NativeFileSessionHandler extends NativeSessionHandler
      */
     public function __construct($savePath = null)
     {
+        // We don't want to override the server settings in case the server is configured to handle sessions
+        // in something else than files. This makes it easy to configure servers to have sessions stored in
+        // memcached/redis or anything else from PHP.ini
+        if ('files' != ini_get('session.save_handler')) {
+            return;
+        }
+
         if (null === $savePath) {
             $savePath = ini_get('session.save_path');
         }

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,13 @@ class NativeFileSessionHandler extends NativeSessionHandler`
`33`	`33`	`*/`
`34`	`34`	`public function __construct($savePath = null)`
`35`	`35`	`{`
	`36`	`+ // We don't want to override the server settings in case the server is configured to handle sessions`
	`37`	`+ // in something else than files. This makes it easy to configure servers to have sessions stored in`
	`38`	`+ // memcached/redis or anything else from PHP.ini`
	`39`	`+ if ('files' != ini_get('session.save_handler')) {`
	`40`	`+ return;`
	`41`	`+ }`
	`42`	`+`
`36`	`43`	`if (null === $savePath) {`
`37`	`44`	`$savePath = ini_get('session.save_path');`
`38`	`45`	`}`