8000 Support use of hyphen in asset package name · symfony/symfony@30b6a4f · GitHub
[go: up one dir, main page]
Skip to content

Commit 30b6a4f

Browse files
damayaAnthony MARTIN
damaya
authored and
Anthony MARTIN
committed
Support use of hyphen in asset package name
| Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (Manual tests only) | Fixed tickets | #28122 | License | MIT | Doc PR | n/a According to issue symfony/symfony-docs#10442, we tested in a demo bundle, for example in src/AppBundle/Resources/config/config.yml a package using hyphens: app-client-frontend, and withouth the patch it fails because the package is not recognized. With the patch, it works as expected. ``` framework: assets: packages: app-client-frontend: version: "%env(FRONTEND_VERSION)%" version_format: '%%2$s/dist/%%1$s' base_urls: - "%env(FRONTEND_URL)%" ```
1 parent f797a78 commit 30b6a4f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -642,6 +642,7 @@ private function addAssetsSection(ArrayNodeDefinition $rootNode)
642642
->fixXmlConfig('package')
643643
->children()
644644
->arrayNode('packages')
645+
->normalizeKeys(false)
645646
->useAttributeAsKey('name')
646647
->prototype('array')
647648
->fixXmlConfig('base_url')

0 commit comments

Comments
 (0)
0