feature #48362 [Clock] Add ClockAwareTrait to help write time-sensitive classes (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 309b10a0e59a · 2022-12-05T13:56:25.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [Clock] Add ClockAwareTrait to help write time-sensitive classes | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Add the trait and use `$this->now()` inside the class, autowiring will do the magic 💪 Commits ------- 8e2af95 [Clock] Add ClockAwareTrait to help write time-sensitive classes
diff --git a/src/Symfony/Component/Clock/CHANGELOG.md b/src/Symfony/Component/Clock/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.3
+---
+
+ * Add `ClockAwareTrait` to help write time-sensitive classes
+
 6.2
 ---
 
diff --git a/src/Symfony/Component/Clock/ClockAwareTrait.php b/src/Symfony/Component/Clock/ClockAwareTrait.php
@@ -0,0 +1,36 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Clock;
+
+use Psr\Clock\ClockInterface;
+use Symfony\Contracts\Service\Attribute\Required;
+
+/**
+ * A trait to help write time-sensitive classes.
+ *
+ * @author Nicolas Grekas <p@tchwork.com>
+ */
+trait ClockAwareTrait
+{
+    private readonly ClockInterface $clock;
+
+    #[Required]
+    public function setClock(ClockInterface $clock): void
+    {
+        $this->clock = $clock;
+    }
+
+    protected function now(): \DateTimeImmutable
+    {
+        return ($this->clock ??= new NativeClock())->now();
+    }
+}
diff --git a/src/Symfony/Component/Clock/Tests/ClockAwareTraitTest.php b/src/Symfony/Component/Clock/Tests/ClockAwareTraitTest.php
@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Clock\Tests;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Clock\ClockAwareTrait;
+use Symfony\Component\Clock\MockClock;
+
+class ClockAwareTraitTest extends TestCase
+{
+    public function testTrait()
+    {
+        $sut = new class() {
+            use ClockAwareTrait {
+                now as public;
+            }
+        };
+
+        $this->assertInstanceOf(\DateTimeImmutable::class, $sut->now());
+
+        $clock = new MockClock();
+        $sut = new $sut();
+        $sut->setClock($clock);
+
+        $ts = $sut->now()->getTimestamp();
+        $this->assertEquals($clock->now(), $sut->now());
+        $clock->sleep(1);
+        $this->assertEquals($clock->now(), $sut->now());
+        $this->assertSame(1.0, round($sut->now()->getTimestamp() - $ts, 1));
+    }
+}
