bug #59769 Enable JSON_PRESERVE_ZERO_FRACTION in jsonRequest method (raffaelecarelle)

fabpot · fabpot · commit 3062f0547db2 · 2025-02-14T12:23:25.000+01:00
This PR was submitted for the 7.2 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- Enable `JSON_PRESERVE_ZERO_FRACTION` in `jsonRequest` method | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Updated the jsonRequest method to use JSON_PRESERVE_ZERO_FRACTION when encoding parameters. This avoid unintended cast to int. Test case: ``` $this->browser->jsonRequest('GET', 'url', ['cost' => 10.0]); ``` "cost" will be cast to int `10` Commits ------- 535953e Enable `JSON_PRESERVE_ZERO_FRACTION` in `jsonRequest` method
diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
@@ -170,7 +170,7 @@ public function xmlHttpRequest(string $method, string $uri, array $parameters =
      */
     public function jsonRequest(string $method, string $uri, array $parameters = [], array $server = [], bool $changeHistory = true): Crawler
     {
-        $content = json_encode($parameters);
+        $content = json_encode($parameters, \JSON_PRESERVE_ZERO_FRACTION);
 
         $this->setServerParameter('CONTENT_TYPE', 'application/json');
         $this->setServerParameter('HTTP_ACCEPT', 'application/json');
diff --git a/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php b/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php
@@ -67,12 +67,12 @@ public function testXmlHttpRequest()
     public function testJsonRequest()
     {
         $client = $this->getBrowser();
-        $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);
+        $client->jsonRequest('GET', 'http://example.com/', ['param' => 1, 'float' => 10.0], [], true);
         $this->assertSame('application/json', $client->getRequest()->getServer()['CONTENT_TYPE']);
         $this->assertSame('application/json', $client->getRequest()->getServer()['HTTP_ACCEPT']);
         $this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));
         $this->assertFalse($client->getServerParameter('HTTP_ACCEPT', false));
-        $this->assertSame('{"param":1}', $client->getRequest()->getContent());
+        $this->assertSame('{"param":1,"float":10.0}', $client->getRequest()->getContent());
     }
 
     public function testGetRequestWithIpAsHttpHost()

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ public function xmlHttpRequest(string $method, string $uri, array $parameters =`
`170`	`170`	`*/`
`171`	`171`	`public function jsonRequest(string $method, string $uri, array $parameters = [], array $server = [], bool $changeHistory = true): Crawler`
`172`	`172`	`{`
`173`		`- $content = json_encode($parameters);`
	`173`	`+ $content = json_encode($parameters, \JSON_PRESERVE_ZERO_FRACTION);`
`174`	`174`
`175`	`175`	`$this->setServerParameter('CONTENT_TYPE', 'application/json');`
`176`	`176`	`$this->setServerParameter('HTTP_ACCEPT', 'application/json');`
Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,12 @@ public function testXmlHttpRequest()`
`67`	`67`	`public function testJsonRequest()`
`68`	`68`	`{`
`69`	`69`	`$client = $this->getBrowser();`
`70`		`- $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);`
	`70`	`+ $client->jsonRequest('GET', 'http://example.com/', ['param' => 1, 'float' => 10.0], [], true);`
`71`	`71`	`$this->assertSame('application/json', $client->getRequest()->getServer()['CONTENT_TYPE']);`
`72`	`72`	`$this->assertSame('application/json', $client->getRequest()->getServer()['HTTP_ACCEPT']);`
`73`	`73`	`$this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));`
`74`	`74`	`$this->assertFalse($client->getServerParameter('HTTP_ACCEPT', false));`
`75`		`- $this->assertSame('{"param":1}', $client->getRequest()->getContent());`
	`75`	`+ $this->assertSame('{"param":1,"float":10.0}', $client->getRequest()->getContent());`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`public function testGetRequestWithIpAsHttpHost()`