[DI] fix InlineServiceDefinitionsPass' fix

nicolas-grekas · nicolas-grekas · commit 302ff0a0ae2c · 2018-12-01T10:29:46.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -92,11 +92,11 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe
             return false;
         }
 
-        if (!$graph->hasNode($id)) {
-            return true;
-        }
-
         if (!$definition->isShared()) {
+            if (!$graph->hasNode($id)) {
+                return true;
+            }
+
             foreach ($graph->getNode($id)->getInEdges() as $edge) {
                 if ($edge->isWeak()) {
                     return false;
@@ -110,6 +110,10 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe
             return false;
         }
 
+        if (!$graph->hasNode($id)) {
+            return true;
+        }
+
         if ($this->currentId == $id) {
             return false;
         }
