minor #18500 [DependencyInjection] Add coverage for all invalid arguments in exportParameters (JhonnyL)

fabpot · fabpot · commit 302e1928b896 · 2016-04-11T05:47:06.000-07:00
This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Add coverage for all invalid arguments in exportParameters | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 87c4f23 [DependencyInjection] Add coverage for all invalid arguments in exportParameters
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
@@ -16,6 +16,7 @@
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\DependencyInjection\Variable;
 
 class PhpDumperTest extends \PHPUnit_Framework_TestCase
 {
@@ -100,14 +101,24 @@ public function testDumpRelativeDir()
     }
 
     /**
+     * @dataProvider provideInvalidParameters
      * @expectedException \InvalidArgumentException
      */
-    public function testExportParameters()
+    public function testExportParameters($parameters)
     {
-        $dumper = new PhpDumper(new ContainerBuilder(new ParameterBag(array('foo' => new Reference('foo')))));
+        $dumper = new PhpDumper(new ContainerBuilder(new ParameterBag($parameters)));
         $dumper->dump();
     }
 
+    public function provideInvalidParameters()
+    {
+        return array(
+            array(array('foo' => new Definition('stdClass'))),
+            array(array('foo' => new Reference('foo'))),
+            array(array('foo' => new Variable('foo'))),
+        );
+    }
+
     public function testAddParameters()
     {
         $container = include self::$fixturesPath.'/containers/container8.php';
