Do not throw exception on valut generate key

jderusse · jderusse · commit 2f608b4dfa43 · 2019-12-24T14:11:19.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Secrets/SodiumVault.php b/src/Symfony/Bundle/FrameworkBundle/Secrets/SodiumVault.php
@@ -47,7 +47,9 @@ public function generateKeys(bool $override = false): bool
         $this->lastMessage = null;
 
         if (null === $this->encryptionKey && '' !== $this->decryptionKey = (string) $this->decryptionKey) {
-            throw new \LogicException('Cannot generate keys when a decryption key has been provided while instantiating the vault.');
+            $this->lastMessage = 'Cannot generate keys when a decryption key has been provided while instantiating the vault.';
+
+            return false;
         }
 
         try {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,9 @@ public function generateKeys(bool $override = false): bool`
`47`	`47`	`$this->lastMessage = null;`
`48`	`48`
`49`	`49`	`if (null === $this->encryptionKey && '' !== $this->decryptionKey = (string) $this->decryptionKey) {`
`50`		`- throw new \LogicException('Cannot generate keys when a decryption key has been provided while instantiating the vault.');`
	`50`	`+ $this->lastMessage = 'Cannot generate keys when a decryption key has been provided while instantiating the vault.';`
	`51`	`+`
	`52`	`+ return false;`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`try {`