bug #40246 [EventDispatcher] fix registering subscribers twice on edge-case (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 2f4cd77e0466 · 2021-02-18T21:49:41.000+01:00
This PR was merged into the 5.2 branch. Discussion ---------- [EventDispatcher] fix registering subscribers twice on edge-case | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Introduced on 5.1 in #36243 Commits ------- ad60072 [EventDispatcher] fix registering subscribers twice on edge-case
diff --git a/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php b/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php
@@ -149,7 +149,7 @@ public function process(ContainerBuilder $container)
                     continue;
                 }
 
-                $dispatcherDefinitions[] = $container->getDefinition($attributes['dispatcher']);
+                $dispatcherDefinitions[$attributes['dispatcher']] = $container->getDefinition($attributes['dispatcher']);
             }
 
             if (!$dispatcherDefinitions) {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ public function process(ContainerBuilder $container)`
`149`	`149`	`continue;`
`150`	`150`	`}`
`151`	`151`
`152`		`- $dispatcherDefinitions[] = $container->getDefinition($attributes['dispatcher']);`
	`152`	`+ $dispatcherDefinitions[$attributes['dispatcher']] = $container->getDefinition($attributes['dispatcher']);`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`if (!$dispatcherDefinitions) {`