minor #40648 [Notifier] [FakeSms] Change DSN to be more realistic (OskarStark)

Nyholm · Nyholm · commit 2f2015602116 · 2021-03-31T09:55:22.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] [FakeSms] Change DSN to be more realistic | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | Follows #39949 | License | MIT | Doc PR | symfony/symfony-docs#...  Just a minor tests change Commits ------- 0b13575 [Notifier] [FakeSms] Change DSN to be more realistic
diff --git a/src/Symfony/Component/Notifier/Bridge/FakeSms/Tests/FakeSmsTransportFactoryTest.php b/src/Symfony/Component/Notifier/Bridge/FakeSms/Tests/FakeSmsTransportFactoryTest.php
@@ -51,7 +51,7 @@ public function missingRequiredOptionProvider(): iterable
     public function supportsProvider(): iterable
     {
         yield [true, 'fakesms+email://mailer?to=recipient@email.net&from=sender@email.net'];
-        yield [false, 'somethingElse://api_token@default?from=MyCompany'];
+        yield [false, 'somethingElse://mailer?to=recipient@email.net&from=sender@email.net'];
     }
 
     public function incompleteDsnProvider(): iterable
@@ -62,7 +62,6 @@ public function incompleteDsnProvider(): iterable
 
     public function unsupportedSchemeProvider(): iterable
     {
-        yield ['foobar://api_token@default?from=MyCompany'];
-        yield ['foobar://api_token@default'];
+        yield ['somethingElse://mailer?to=recipient@email.net&from=sender@email.net'];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function missingRequiredOptionProvider(): iterable`
`51`	`51`	`public function supportsProvider(): iterable`
`52`	`52`	`{`
`53`	`53`	`yield [true, 'fakesms+email://mailer?to=recipient@email.net&from=sender@email.net'];`
`54`		`- yield [false, 'somethingElse://api_token@default?from=MyCompany'];`
	`54`	`+ yield [false, 'somethingElse://mailer?to=recipient@email.net&from=sender@email.net'];`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`public function incompleteDsnProvider(): iterable`
`@@ -62,7 +62,6 @@ public function incompleteDsnProvider(): iterable`
`62`	`62`
`63`	`63`	`public function unsupportedSchemeProvider(): iterable`
`64`	`64`	`{`
`65`		`- yield ['foobar://api_token@default?from=MyCompany'];`
`66`		`- yield ['foobar://api_token@default'];`
	`65`	`+ yield ['somethingElse://mailer?to=recipient@email.net&from=sender@email.net'];`
`67`	`66`	`}`
`68`	`67`	`}`