Final refactor

javiereguiluz · javiereguiluz · commit 2e8373bb9de6 · 2018-07-26T12:16:48.000+02:00
diff --git a/src/Symfony/Component/DomCrawler/Tests/ImageTest.php b/src/Symfony/Component/DomCrawler/Tests/ImageTest.php
@@ -27,16 +27,7 @@ public function testConstructorWithANonImgTag()
         new Image($dom->getElementsByTagName('div')->item(0), 'http://www.example.com/');
     }
 
-    public function testBaseUriIsOptional()
-    {
-        $dom = new \DOMDocument();
-        $dom->loadHTML('<html><img alt="foo" src="https://example.com/foo" /></html>');
-
-        $image = new Image($dom->getElementsByTagName('img')->item(0));
-        $this->assertSame('foo', $image->getNode()->getAttribute('alt'));
-    }
-
-    public function testBaseUriIsOptionaIfImageContainsAbsoluteUrl()
+    public function testBaseUriIsOptionalWhenImageUrlIsAbsolute()
     {
         $dom = new \DOMDocument();
         $dom->loadHTML('<html><img alt="foo" src="https://example.com/foo" /></html>');
@@ -48,7 +39,7 @@ public function testBaseUriIsOptionaIfImageContainsAbsoluteUrl()
     /**
      * @expectedException \InvalidArgumentException
      */
-    public function testBaseUriMustBeAnAbsoluteUrlWhenImageUrlIsRelative()
+    public function testAbsoluteBaseUriIsMandatoryWhenImageUrlIsRelative()
     {
         $dom = new \DOMDocument();
         $dom->loadHTML('<html><img alt="foo" src="/foo" /></html>');
diff --git a/src/Symfony/Component/DomCrawler/Tests/LinkTest.php b/src/Symfony/Component/DomCrawler/Tests/LinkTest.php
@@ -27,16 +27,7 @@ public function testConstructorWithANonATag()
         new Link($dom->getElementsByTagName('div')->item(0), 'http://www.example.com/');
     }
 
-    public function testBaseUriIsOptional()
-    {
-        $dom = new \DOMDocument();
-        $dom->loadHTML('<html><a href="/foo">foo</a></html>');
-
-        $link = new Link($dom->getElementsByTagName('a')->item(0));
-        $this->assertSame('foo', $link->getNode()->nodeValue);
-    }
-
-    public function testBaseUriIsOptionaIfLinkContainsAbsoluteUrl()
+    public function testBaseUriIsOptionalWhenLinkUrlIsAbsolute()
     {
         $dom = new \DOMDocument();
         $dom->loadHTML('<html><a href="https://example.com/foo">foo</a></html>');
@@ -48,7 +39,7 @@ public function testBaseUriIsOptionaIfLinkContainsAbsoluteUrl()
     /**
      * @expectedException \InvalidArgumentException
      */
-    public function testBaseUriMustBeAnAbsoluteUrlWhenLinkUrlIsRelative()
+    public function testAbsoluteBaseUriIsMandatoryWhenLinkUrlIsRelative()
     {
         $dom = new \DOMDocument();
         $dom->loadHTML('<html><a href="/foo">foo</a></html>');
