bug #53381 [Form] Fix assigning data in PostSetDataEvent and PostSubmitEvent (fancyweb)

xabbuh · xabbuh · commit 2e73037454b3 · 2024-01-04T08:43:52.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Form] Fix assigning data in `PostSetDataEvent` and `PostSubmitEvent` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #53364 | License | MIT Ref #51043 where we changed the behavior on 6.4 since we don't assign the data property anymore. cc `@HeahDude` Commits ------- 61d71c4 [Form] Fix assigning data in PostSetDataEvent and PostSubmitEvent
diff --git a/src/Symfony/Component/Form/Event/PostSetDataEvent.php b/src/Symfony/Component/Form/Event/PostSetDataEvent.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Form\Event;
 
-use Symfony\Component\Form\Exception\BadMethodCallException;
 use Symfony\Component\Form\FormEvent;
 
 /**
@@ -29,5 +28,6 @@ public function setData(mixed $data): void
     {
         trigger_deprecation('symfony/form', '6.4', 'Calling "%s()" will throw an exception as of 7.0, listen to "form.pre_set_data" instead.', __METHOD__);
         // throw new BadMethodCallException('Form data cannot be changed during "form.post_set_data", you should use "form.pre_set_data" instead.');
+        parent::setData($data);
     }
 }
diff --git a/src/Symfony/Component/Form/Event/PostSubmitEvent.php b/src/Symfony/Component/Form/Event/PostSubmitEvent.php
@@ -28,5 +28,6 @@ public function setData(mixed $data): void
     {
         trigger_deprecation('symfony/form', '6.4', 'Calling "%s()" will throw an exception as of 7.0, listen to "form.pre_submit" or "form.submit" instead.', __METHOD__);
         // throw new BadMethodCallException('Form data cannot be changed during "form.post_submit", you should use "form.pre_submit" or "form.submit" instead.');
+        parent::setData($data);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Form\Event;`
`13`	`13`
`14`		`-use Symfony\Component\Form\Exception\BadMethodCallException;`
`15`	`14`	`use Symfony\Component\Form\FormEvent;`
`16`	`15`
`17`	`16`	`/**`
`@@ -29,5 +28,6 @@ public function setData(mixed $data): void`
`29`	`28`	`{`
`30`	`29`	`trigger_deprecation('symfony/form', '6.4', 'Calling "%s()" will throw an exception as of 7.0, listen to "form.pre_set_data" instead.', __METHOD__);`
`31`	`30`	`// throw new BadMethodCallException('Form data cannot be changed during "form.post_set_data", you should use "form.pre_set_data" instead.');`
	`31`	`+ parent::setData($data);`
`32`	`32`	`}`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,6 @@ public function setData(mixed $data): void`
`28`	`28`	`{`
`29`	`29`	`trigger_deprecation('symfony/form', '6.4', 'Calling "%s()" will throw an exception as of 7.0, listen to "form.pre_submit" or "form.submit" instead.', __METHOD__);`
`30`	`30`	`// throw new BadMethodCallException('Form data cannot be changed during "form.post_submit", you should use "form.pre_submit" or "form.submit" instead.');`
	`31`	`+ parent::setData($data);`
`31`	`32`	`}`
`32`	`33`	`}`