feature #49781 [Translation] Improve message extraction performance for big code bases (welcoMattic)

fabpot · fabpot · commit 2e31041c504d · 2023-03-25T09:35:08.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [Translation] Improve message extraction performance for big code bases | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes  | Deprecations? | no  | Tickets | Fix #49585  | License | MIT | Doc PR | As discussed in #49585, we try to extract messages from all src/ directory in `translation:debug` and `translation:extract` commands. But, it's not necessary to look into all files, as we can easily detect if a file contains something about translation (with some regexes). This PR filter files before messages extraction, and it divide by at least 3 the time used to extract messages from an app with 100 000 php files. Commits ------- ae6c25b fix(translation): Improve performance of debug and extract command for big code base
diff --git a/src/Symfony/Component/Translation/Extractor/PhpAstExtractor.php b/src/Symfony/Component/Translation/Extractor/PhpAstExtractor.php
@@ -64,7 +64,9 @@ public function setPrefix(string $prefix): void
 
     protected function canBeExtracted(string $file): bool
     {
-        return 'php' === pathinfo($file, \PATHINFO_EXTENSION) && $this->isFile($file);
+        return 'php' === pathinfo($file, \PATHINFO_EXTENSION)
+            && $this->isFile($file)
+            && preg_match('/\bt\(|->trans\(|TranslatableMessage|Symfony\\\\Component\\\\Validator\\\\Constraints/i', file_get_contents($file));
     }
 
     protected function extractFromDirectory(array|string $resource): iterable|Finder
diff --git a/src/Symfony/Component/Translation/Extractor/Visitor/ConstraintVisitor.php b/src/Symfony/Component/Translation/Extractor/Visitor/ConstraintVisitor.php
@@ -21,8 +21,6 @@
  */
 final class ConstraintVisitor extends AbstractVisitor implements NodeVisitor
 {
-    private const CONSTRAINT_VALIDATION_MESSAGE_PATTERN = '/[a-zA-Z]*message/i';
-
     public function __construct(
         private readonly array $constraintClassNames = []
     ) {
@@ -65,7 +63,7 @@ public function enterNode(Node $node): ?Node
         }
 
         if ($this->hasNodeNamedArguments($node)) {
-            $messages = $this->getStringArguments($node, self::CONSTRAINT_VALIDATION_MESSAGE_PATTERN, true);
+            $messages = $this->getStringArguments($node, '/message/i', true);
         } else {
             if (!$arg->value instanceof Node\Expr\Array_) {
                 // There is no way to guess which argument is a message to be translated.
@@ -81,7 +79,7 @@ public function enterNode(Node $node): ?Node
                     continue;
                 }
 
-                if (!preg_match(self::CONSTRAINT_VALIDATION_MESSAGE_PATTERN, $item->key->value ?? '')) {
+                if (false === stripos($item->key->value ?? '', 'message')) {
                     continue;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,9 @@ public function setPrefix(string $prefix): void`
`64`	`64`
`65`	`65`	`protected function canBeExtracted(string $file): bool`
`66`	`66`	`{`
`67`		`- return 'php' === pathinfo($file, \PATHINFO_EXTENSION) && $this->isFile($file);`
	`67`	`+ return 'php' === pathinfo($file, \PATHINFO_EXTENSION)`
	`68`	`+ && $this->isFile($file)`
	`69`	`+ && preg_match('/\bt\(\|->trans\(\|TranslatableMessage\|Symfony\\\\Component\\\\Validator\\\\Constraints/i', file_get_contents($file));`
`68`	`70`	`}`
`69`	`71`
`70`	`72`	`protected function extractFromDirectory(array\|string $resource): iterable\|Finder`
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@`
`21`	`21`	`*/`
`22`	`22`	`final class ConstraintVisitor extends AbstractVisitor implements NodeVisitor`
`23`	`23`	`{`
`24`		`- private const CONSTRAINT_VALIDATION_MESSAGE_PATTERN = '/[a-zA-Z]*message/i';`
`25`		`-`
`26`	`24`	`public function __construct(`
`27`	`25`	`private readonly array $constraintClassNames = []`
`28`	`26`	`) {`
`@@ -65,7 +63,7 @@ public function enterNode(Node $node): ?Node`
`65`	`63`	`}`
`66`	`64`
`67`	`65`	`if ($this->hasNodeNamedArguments($node)) {`
`68`		`- $messages = $this->getStringArguments($node, self::CONSTRAINT_VALIDATION_MESSAGE_PATTERN, true);`
	`66`	`+ $messages = $this->getStringArguments($node, '/message/i', true);`
`69`	`67`	`} else {`
`70`	`68`	`if (!$arg->value instanceof Node\Expr\Array_) {`
`71`	`69`	`// There is no way to guess which argument is a message to be translated.`
`@@ -81,7 +79,7 @@ public function enterNode(Node $node): ?Node`
`81`	`79`	`continue;`
`82`	`80`	`}`
`83`	`81`
`84`		`- if (!preg_match(self::CONSTRAINT_VALIDATION_MESSAGE_PATTERN, $item->key->value ?? '')) {`
	`82`	`+ if (false === stripos($item->key->value ?? '', 'message')) {`
`85`	`83`	`continue;`
`86`	`84`	`}`
`87`	`85`