feature #49805 [Mailer] Update default Mailgun port (dreadnip)

fabpot · fabpot · commit 2e2eaad56e52 · 2023-03-25T09:55:32.000+01:00
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Mailer] Update default Mailgun port | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT Alternative to #49768. Instead of passing the port from the DSN, update the default to 587, which is recommended by Mailgun. I've also opened a docs PR to clarify that specific bridge DSNs ignore the port: symfony/symfony-docs#18118 Commits ------- 05e9be7 [Mailer] Update default Mailgun port
diff --git a/src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunSmtpTransport.php b/src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunSmtpTransport.php
@@ -24,7 +24,7 @@ class MailgunSmtpTransport extends EsmtpTransport
 
     public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
     {
-        parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 465, true, $dispatcher, $logger);
+        parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, true, $dispatcher, $logger);
 
         $this->setUsername($username);
         $this->setPassword($password);
diff --git a/src/Symfony/Component/Mailer/CHANGELOG.md b/src/Symfony/Component/Mailer/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add `MessageEvent::reject()` to allow rejecting an email before sending it
+ * Change the default port for the `mailgun+smtp` transport from 465 to 587
 
 6.2.7
 -----

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class MailgunSmtpTransport extends EsmtpTransport`
`24`	`24`
`25`	`25`	`public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)`
`26`	`26`	`{`
`27`		`- parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 465, true, $dispatcher, $logger);`
	`27`	`+ parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, true, $dispatcher, $logger);`
`28`	`28`
`29`	`29`	`$this->setUsername($username);`
`30`	`30`	`$this->setPassword($password);`