bug #53671 [HttpClient] Fix pausing responses before they start when using curl (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 2e025f96335b · 2024-01-29T15:19:06.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Fix pausing responses before they start when using curl | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53622 | License | MIT Curl doesn't support pausing responses before they started, that's why the call to `curl_multi_remove_handle` is needed. But the removed line breaks tracking responses that did start. Commits ------- c6c5303 [HttpClient] Fix pausing responses before they start when using curl
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -95,7 +95,6 @@ public function __construct(CurlClientState $multi, $ch, ?array $options = null,
         $this->info['pause_handler'] = static function (float $duration) use ($ch, $multi, $execCounter) {
             if (0 < $duration) {
                 if ($execCounter === $multi->execCounter) {
-                    $multi->execCounter = !\is_float($execCounter) ? 1 + $execCounter : \PHP_INT_MIN;
                     curl_multi_remove_handle($multi->handle, $ch);
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,6 @@ public function __construct(CurlClientState $multi, $ch, ?array $options = null,`
`95`	`95`	`$this->info['pause_handler'] = static function (float $duration) use ($ch, $multi, $execCounter) {`
`96`	`96`	`if (0 < $duration) {`
`97`	`97`	`if ($execCounter === $multi->execCounter) {`
`98`		`- $multi->execCounter = !\is_float($execCounter) ? 1 + $execCounter : \PHP_INT_MIN;`
`99`	`98`	`curl_multi_remove_handle($multi->handle, $ch);`
`100`	`99`	`}`
`101`	`100`