bug #53730 [Messenger] [Beanstalkd] fix tube stats when it's empty (eminjk)

nicolas-grekas · nicolas-grekas · commit 2bfac0dc6791 · 2024-02-05T16:45:09.000+01:00
This PR was submitted for the 6.4 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Messenger] [Beanstalkd] fix tube stats when it's empty | Q | A | ------------- | --- | Branch? | 6.4  | Bug fix? | yes | New feature? | no  | Deprecations? |no  | Issues | Fix #53526  | License | MIT  When Beanstalkd's tube was empty `messenger:stats` commands throws an `NOT_FOUND` error instead of 0. Initializing tube before retrieving tube stats force beanstalkd to created it and then it returns proper value. Commits ------- 22e105d prevent throwing NOT_FOUND error when tube is empty
diff --git a/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/Connection.php
@@ -182,6 +182,7 @@ public function reject(string $id): void
     public function getMessageCount(): int
     {
         try {
+            $this->client->useTube($this->tube);
             $tubeStats = $this->client->statsTube($this->tube);
         } catch (Exception $exception) {
             throw new TransportException($exception->getMessage(), 0, $exception);

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,7 @@ public function reject(string $id): void`
`182`	`182`	`public function getMessageCount(): int`
`183`	`183`	`{`
`184`	`184`	`try {`
	`185`	`+ $this->client->useTube($this->tube);`
`185`	`186`	`$tubeStats = $this->client->statsTube($this->tube);`
`186`	`187`	`} catch (Exception $exception) {`
`187`	`188`	`throw new TransportException($exception->getMessage(), 0, $exception);`