bug #9223 [Translator] PoFileDumper - PO headers (Padam87)

fabpot · fabpot · commit 2ae07b5fb150 · 2013-10-09T22:59:37.000+02:00
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9223). Discussion ---------- [Translator] PoFileDumper - PO headers | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6765 - partially | License | MIT | Doc PR | Po files should not be dumped without a header. It causes a lot of problems, including charset issues. See #6765 / 1 for more info Commits ------- e93bc50 [Translator] PoFileDumper - PO headers
diff --git a/src/Symfony/Component/Translation/Dumper/PoFileDumper.php b/src/Symfony/Component/Translation/Dumper/PoFileDumper.php
@@ -25,7 +25,13 @@ class PoFileDumper extends FileDumper
      */
     public function format(MessageCatalogue $messages, $domain = 'messages')
     {
-        $output = '';
+        $output = 'msgid ""'."\n";
+        $output .= 'msgstr ""'."\n";
+        $output .= '"Content-Type: text/plain; charset=UTF-8\n"'."\n";
+        $output .= '"Content-Transfer-Encoding: 8bit\n"'."\n";
+        $output .= '"Language: '.$messages->getLocale().'\n"'."\n";
+        $output .= "\n";
+
         $newLine = false;
         foreach ($messages->all($domain) as $source => $target) {
             if ($newLine) {
diff --git a/src/Symfony/Component/Translation/Tests/fixtures/resources.po b/src/Symfony/Component/Translation/Tests/fixtures/resources.po
@@ -1,2 +1,8 @@
+msgid ""
+msgstr ""
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Language: en\n"
+
 msgid "foo"
 msgstr "bar"
