bug #50514 [PhpUnitBridge] Disable deduplication of Doctrine deprecations (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 29fe9ffd6f7b · 2023-06-01T10:10:44.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [PhpUnitBridge] Disable deduplication of Doctrine deprecations | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Deprecation reports are not accurate with deduplication enabled. Commits ------- 03392b6 [PhpUnitBridge] Disable deduplication of Doctrine deprecations
diff --git a/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php b/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php
@@ -260,6 +260,8 @@
         if ('\\' === \DIRECTORY_SEPARATOR) {
             file_put_contents('composer.json', preg_replace('/^( {8})"phpunit-bridge": \{$/m', "$0\n$1    ".'"options": {"symlink": false},', file_get_contents('composer.json')));
         }
+        $phpunitBridgeComposerJson = file_get_contents($path.'/composer.json');
+        file_put_contents($path.'/composer.json', preg_replace('/^( {8})"files": .*/m', '', $phpunitBridgeComposerJson));
     } else {
         $passthruOrFail("$COMPOSER require --no-update symfony/phpunit-bridge \"*\"");
     }
@@ -269,6 +271,9 @@
     // --no-suggest is not in the list to keep compat with composer 1.0, which is shipped with Ubuntu 16.04LTS
     $exit = proc_close(proc_open("$q$COMPOSER install --no-dev --prefer-dist --no-progress $q", [], $p, getcwd()));
     putenv('COMPOSER_ROOT_VERSION'.(false !== $prevRoot ? '='.$prevRoot : ''));
+    if (file_exists($path)) {
+        file_put_contents($path.'/composer.json', $phpunitBridgeComposerJson);
+    }
     if ($prevCacheDir) {
         putenv("COMPOSER_CACHE_DIR=$prevCacheDir");
     }
diff --git a/src/Symfony/Bridge/PhpUnit/bootstrap.php b/src/Symfony/Bridge/PhpUnit/bootstrap.php
@@ -10,10 +10,11 @@
  */
 
 use Doctrine\Common\Annotations\AnnotationRegistry;
+use Doctrine\Deprecations\Deprecation;
 use Symfony\Bridge\PhpUnit\DeprecationErrorHandler;
 
 // Detect if we need to serialize deprecations to a file.
-if ($file = getenv('SYMFONY_DEPRECATIONS_SERIALIZE')) {
+if (in_array(PHP_SAPI, ['cli', 'phpdbg'], true) && $file = getenv('SYMFONY_DEPRECATIONS_SERIALIZE')) {
     DeprecationErrorHandler::collectDeprecations($file);
 
     return;
@@ -27,6 +28,10 @@
 // Enforce a consistent locale
 setlocale(\LC_ALL, 'C');
 
+if (class_exists(Deprecation::class)) {
+    Deprecation::withoutDeduplication();
+}
+
 if (!class_exists(AnnotationRegistry::class, false) && class_exists(AnnotationRegistry::class)) {
     if (method_exists(AnnotationRegistry::class, 'registerUniqueLoader')) {
         AnnotationRegistry::registerUniqueLoader('class_exists');

Original file line number	Diff line number	Diff line change
`@@ -260,6 +260,8 @@`
`260`	`260`	`if ('\\' === \DIRECTORY_SEPARATOR) {`
`261`	`261`	`file_put_contents('composer.json', preg_replace('/^( {8})"phpunit-bridge": \{$/m', "$0\n$1 ".'"options": {"symlink": false},', file_get_contents('composer.json')));`
`262`	`262`	`}`
	`263`	`+ $phpunitBridgeComposerJson = file_get_contents($path.'/composer.json');`
	`264`	`+ file_put_contents($path.'/composer.json', preg_replace('/^( {8})"files": .*/m', '', $phpunitBridgeComposerJson));`
`263`	`265`	`} else {`
`264`	`266`	`$passthruOrFail("$COMPOSER require --no-update symfony/phpunit-bridge \"*\"");`
`265`	`267`	`}`
`@@ -269,6 +271,9 @@`
`269`	`271`	`// --no-suggest is not in the list to keep compat with composer 1.0, which is shipped with Ubuntu 16.04LTS`
`270`	`272`	`$exit = proc_close(proc_open("$q$COMPOSER install --no-dev --prefer-dist --no-progress $q", [], $p, getcwd()));`
`271`	`273`	`putenv('COMPOSER_ROOT_VERSION'.(false !== $prevRoot ? '='.$prevRoot : ''));`
	`274`	`+ if (file_exists($path)) {`
	`275`	`+ file_put_contents($path.'/composer.json', $phpunitBridgeComposerJson);`
	`276`	`+ }`
`272`	`277`	`if ($prevCacheDir) {`
`273`	`278`	`putenv("COMPOSER_CACHE_DIR=$prevCacheDir");`
`274`	`279`	`}`