Return int if scale = 0

VincentLanglet · VincentLanglet · commit 2993fc9fc52b · 2020-02-22T14:29:03.000+01:00
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
@@ -282,7 +282,7 @@ private function round($number)
                     break;
             }
 
-            $number /= $roundingCoef;
+            $number = 1 === $roundingCoef ? (int) $number : $number / $roundingCoef;
         }
 
         return $number;
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -370,7 +370,7 @@ public function testReverseTransformWithRounding($scale, $input, $output, $round
     {
         $transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);
 
-        $this->assertEquals($output, $transformer->reverseTransform($input));
+        $this->assertSame($output, $transformer->reverseTransform($input));
     }
 
     public function testReverseTransformDoesNotRoundIfNoScale()

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ private function round($number)`
`282`	`282`	`break;`
`283`	`283`	`}`
`284`	`284`
`285`		`- $number /= $roundingCoef;`
	`285`	`+ $number = 1 === $roundingCoef ? (int) $number : $number / $roundingCoef;`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`return $number;`
Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ public function testReverseTransformWithRounding($scale, $input, $output, $round`
`370`	`370`	`{`
`371`	`371`	`$transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);`
`372`	`372`
`373`		`- $this->assertEquals($output, $transformer->reverseTransform($input));`
	`373`	`+ $this->assertSame($output, $transformer->reverseTransform($input));`
`374`	`374`	`}`
`375`	`375`
`376`	`376`	`public function testReverseTransformDoesNotRoundIfNoScale()`