minor #58494 [TwigBridge] Add missing return type (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 290b04ab8e2f · 2024-10-08T16:29:11.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [TwigBridge] Add missing return type | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT If I don't miss anything, this exception could be removed from `.github/expected-missing-return-types.diff` and the return type can be added, the class is internal to Symfony. Commits ------- cf949bd [TwigBridge] Add missing return type
diff --git a/.github/expected-missing-return-types.diff b/.github/expected-missing-return-types.diff
@@ -7,16 +7,6 @@ git checkout src/Symfony/Contracts/Service/ResetInterface.php
 (echo "$head" && echo && git diff -U2 src/ | grep '^index ' -v) > .github/expected-missing-return-types.diff
 git checkout composer.json src/
 
-diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php b/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php
---- a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php
-+++ b/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php
-@@ -49,5 +49,5 @@ abstract class AbstractLayoutTestCase extends FormLayoutTestCase
-      * @return FormExtensionInterface[]
-      */
--    protected function getExtensions()
-+    protected function getExtensions(): array
-     {
-         return [
 diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
 --- a/src/Symfony/Component/BrowserKit/AbstractBrowser.php
 +++ b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php b/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php
@@ -48,7 +48,7 @@ protected function setUp(): void
     /**
      * @return FormExtensionInterface[]
      */
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         return [
             new CsrfExtension($this->csrfTokenManager),

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ protected function setUp(): void`
`48`	`48`	`/**`
`49`	`49`	`* @return FormExtensionInterface[]`
`50`	`50`	`*/`
`51`		`- protected function getExtensions()`
	`51`	`+ protected function getExtensions(): array`
`52`	`52`	`{`
`53`	`53`	`return [`
`54`	`54`	`new CsrfExtension($this->csrfTokenManager),`