bug #40498 [DebugBundle] Remove warning of ServerDumpPlaceholderCommand in console (DemigodCode)

nicolas-grekas · nicolas-grekas · commit 285cdb0ecd56 · 2021-03-17T17:59:56.000+01:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [DebugBundle] Remove warning of ServerDumpPlaceholderCommand in console | Q | A | ------------- | --- | Branch? | 5.2.5 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40495 | License | MIT | Doc PR | In 5.2.5 the console commands are lazy. (#39851) With this change the ServerDumpCommand::$defaultName is used which isn't set in the placeholder command. If no vardump-server in debug.dump_destination is defined, this will lead to a warning and not adding the command to the console list. Commits ------- 37b2a19 [DebugBundle] Add $defaultName to PlaceholderCommand
diff --git a/src/Symfony/Bundle/DebugBundle/Command/ServerDumpPlaceholderCommand.php b/src/Symfony/Bundle/DebugBundle/Command/ServerDumpPlaceholderCommand.php
@@ -27,6 +27,9 @@
  */
 class ServerDumpPlaceholderCommand extends Command
 {
+    protected static $defaultName = 'server:dump';
+    protected static $defaultDescription = 'Start a dump server that collects and displays dumps in a single place';
+
     private $replacedCommand;
 
     public function __construct(DumpServer $server = null, array $descriptors = [])

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@`
`27`	`27`	`*/`
`28`	`28`	`class ServerDumpPlaceholderCommand extends Command`
`29`	`29`	`{`
	`30`	`+ protected static $defaultName = 'server:dump';`
	`31`	`+ protected static $defaultDescription = 'Start a dump server that collects and displays dumps in a single place';`
	`32`	`+`
`30`	`33`	`private $replacedCommand;`
`31`	`34`
`32`	`35`	`public function __construct(DumpServer $server = null, array $descriptors = [])`