minor #25795 [HttpFoundation] fix HHVM tests (xabbuh)

nicolas-grekas · nicolas-grekas · commit 277219d0a730 · 2018-01-15T15:53:26.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] fix HHVM tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | | License | MIT | Doc PR | It looks like `parse_url()` broke for some URLs in HHVM 3.18.7. For our tests it IMO isn't really relevant how username and password look like. Commits ------- da21003 fix HHVM tests
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
@@ -45,18 +45,18 @@ public function testGetLocale()
 
     public function testGetUser()
     {
-        $request = Request::create('http://user_test:password_test@test.com/');
+        $request = Request::create('http://user:password@test.com');
         $user = $request->getUser();
 
-        $this->assertEquals('user_test', $user);
+        $this->assertEquals('user', $user);
     }
 
     public function testGetPassword()
     {
-        $request = Request::create('http://user_test:password_test@test.com/');
+        $request = Request::create('http://user:password@test.com');
         $password = $request->getPassword();
 
-        $this->assertEquals('password_test', $password);
+        $this->assertEquals('password', $password);
     }
 
     public function testIsNoCache()

Original file line number	Diff line number	Diff line change
`@@ -45,18 +45,18 @@ public function testGetLocale()`
`45`	`45`
`46`	`46`	`public function testGetUser()`
`47`	`47`	`{`
`48`		`- $request = Request::create('http://user_test:password_test@test.com/');`
	`48`	`+ $request = Request::create('http://user:password@test.com');`
`49`	`49`	`$user = $request->getUser();`
`50`	`50`
`51`		`- $this->assertEquals('user_test', $user);`
	`51`	`+ $this->assertEquals('user', $user);`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`public function testGetPassword()`
`55`	`55`	`{`
`56`		`- $request = Request::create('http://user_test:password_test@test.com/');`
	`56`	`+ $request = Request::create('http://user:password@test.com');`
`57`	`57`	`$password = $request->getPassword();`
`58`	`58`
`59`		`- $this->assertEquals('password_test', $password);`
	`59`	`+ $this->assertEquals('password', $password);`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`public function testIsNoCache()`