fix feedbacks

maxperrimond · maxperrimond · commit 2703ce30b813 · 2020-01-31T13:05:15.000+09:00
diff --git a/src/Symfony/Component/Validator/Constraints/CountryValidator.php b/src/Symfony/Component/Validator/Constraints/CountryValidator.php
@@ -43,8 +43,7 @@ public function validate($value, Constraint $constraint)
 
         $value = (string) $value;
 
-        if ((!$constraint->alpha3 && !Countries::exists($value)) ||
-            ($constraint->alpha3 && !Countries::alpha3CodeExists($value))) {
+        if ($constraint->alpha3 ? !Countries::alpha3CodeExists($value) : !Countries::exists($value)) {
             $this->context->buildViolation($constraint->message)
                 ->setParameter('{{ value }}', $this->formatValue($value))
                 ->setCode(Country::NO_SUCH_COUNTRY_ERROR)
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/CountryValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/CountryValidatorTest.php
@@ -147,6 +147,8 @@ public function getInvalidAlpha3Countries()
         return [
             ['foobar'],
             ['GB'],
+            ['ZZZ'],
+            ['zzz'],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,8 @@ public function getInvalidAlpha3Countries()`
`147`	`147`	`return [`
`148`	`148`	`['foobar'],`
`149`	`149`	`['GB'],`
	`150`	`+ ['ZZZ'],`
	`151`	`+ ['zzz'],`
`150`	`152`	`];`
`151`	`153`	`}`
`152`	`154`