bug #38623 [HttpFoundation][RateLimiter] fix RequestRateLimiterInterface::reset() (kbond)

derrabus · derrabus · commit 2702d81499e8 · 2020-10-19T00:34:45.000+02:00
This PR was merged into the 5.x branch. Discussion ---------- [HttpFoundation][RateLimiter] fix RequestRateLimiterInterface::reset() | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a The reset method requires the `$request`. Commits ------- a246894 fix RequestRateLimiterInterface::reset()
diff --git a/src/Symfony/Component/HttpFoundation/RateLimiter/AbstractRequestRateLimiter.php b/src/Symfony/Component/HttpFoundation/RateLimiter/AbstractRequestRateLimiter.php
@@ -45,7 +45,7 @@ public function consume(Request $request): Limit
         return $minimalLimit;
     }
 
-    public function reset(): void
+    public function reset(Request $request): void
     {
         foreach ($this->getLimiters($request) as $limiter) {
             $limiter->reset();
diff --git a/src/Symfony/Component/HttpFoundation/RateLimiter/RequestRateLimiterInterface.php b/src/Symfony/Component/HttpFoundation/RateLimiter/RequestRateLimiterInterface.php
@@ -28,5 +28,5 @@ interface RequestRateLimiterInterface
 {
     public function consume(Request $request): Limit;
 
-    public function reset(): void;
+    public function reset(Request $request): void;
 }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function consume(Request $request): Limit`
`45`	`45`	`return $minimalLimit;`
`46`	`46`	`}`
`47`	`47`
`48`		`- public function reset(): void`
	`48`	`+ public function reset(Request $request): void`
`49`	`49`	`{`
`50`	`50`	`foreach ($this->getLimiters($request) as $limiter) {`
`51`	`51`	`$limiter->reset();`
Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,5 @@ interface RequestRateLimiterInterface`
`28`	`28`	`{`
`29`	`29`	`public function consume(Request $request): Limit;`
`30`	`30`
`31`		`- public function reset(): void;`
	`31`	`+ public function reset(Request $request): void;`
`32`	`32`	`}`