8000 fix tests on platforms where semaphores are not supported · symfony/symfony@26a0932 · GitHub
[go: up one dir, main page]

Skip to content

Commit 26a0932

Browse files
committed
fix tests on platforms where semaphores are not supported
1 parent d8bc0eb commit 26a0932

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd

+1-1
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@
551551

552552
<xsd:complexType name="lock">
553553
<xsd:sequence>
554-
<xsd:element name="resource" type="lock_resource" minOccurs="1" maxOccurs="unbounded" />
554+
<xsd:element name="resource" type="lock_resource" minOccurs="0" maxOccurs="unbounded" />
555555
</xsd:sequence>
556556
<xsd:attribute name="enabled" type="xsd:boolean" />
557557
</xsd:complexType>

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/lock.xml

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
<framework:config http-method-override="false" handle-all-throwables="true">
99
<framework:annotations enabled="false" />
1010
<framework:php-errors log="true" />
11-
<framework:lock>
12-
<framework:resource>semaphore</framework:resource>
13-
</framework:lock>
11+
<framework:lock />
1412
</framework:config>
1513
</container>

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php

+7-1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
use Symfony\Component\HttpClient\ScopingHttpClient;
5858
use Symfony\Component\HttpKernel\DependencyInjection\LoggerPass;
5959
use Symfony\Component\HttpKernel\Fragment\FragmentUriGeneratorInterface;
60+
use Symfony\Component\Lock\Store\SemaphoreStore;
6061
use Symfony\Component\Messenger\Bridge\AmazonSqs\Transport\AmazonSqsTransportFactory;
6162
use Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransportFactory;
6263
use Symfony\Component\Messenger\Bridge\Beanstalkd\Transport\BeanstalkdTransportFactory;
@@ -2402,7 +2403,12 @@ public function testDefaultLock()
24022403

24032404
self::assertTrue($container->hasDefinition('lock.default.factory'));
24042405
$storeDef = $container->getDefinition($container->getDefinition('lock.default.factory')->getArgument(0));
2405-
self::assertEquals(new Reference('semaphore'), $storeDef->getArgument(0));
2406+
2407+
if (class_exists(SemaphoreStore::class) && SemaphoreStore::isSupported()) {
2408+
self::assertEquals(new Reference('semaphore'), $storeDef->getArgument(0));
2409+
} else {
2410+
self::assertEquals(new Reference('flock'), $storeDef->getArgument(0));
2411+
}
24062412
}
24072413

24082414
public function testNamedLocks()

0 commit comments

Comments
 (0)
0