bug #46808 [HttpFoundation] Fix TypeError on null $_SESSION in NativeSessionStorage::save() (chalasr)

nicolas-grekas · nicolas-grekas · commit 267012554d5b · 2022-07-06T14:34:46.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Fix TypeError on null `$_SESSION` in `NativeSessionStorage::save()` | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When sending concurrent requests via ajax async to a route pointing to a controller requiring an authenticated user through a stateful - session-based - firewall that calls `SessionInterface::save()`, it happens that `$_SESSION` is `null` under some conditions which causes the following error on PHP 8.1: > Exception 'TypeError' with message 'array_keys(): Argument #1 ($array) must be of type array, null given' in /app/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php:246 …app/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php (246) …age::save called at /app/vendor/symfony/http-foundation/Session/Session.php (198) The issue prevents me from upgrading to PHP 8.1 in a project I'm working on with `@jwage`. Commits ------- 05f3e77 [HttpFoundation] Fix TypeError on null `$_SESSION` in `NativeSessionStorage::save()`
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
@@ -256,7 +256,7 @@ public function save()
                 unset($_SESSION[$key]);
             }
         }
-        if ([$key = $this->metadataBag->getStorageKey()] === array_keys($_SESSION)) {
+        if ($_SESSION && [$key = $this->metadataBag->getStorageKey()] === array_keys($_SESSION)) {
             unset($_SESSION[$key]);
         }
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
@@ -321,4 +321,13 @@ public function testRegenerateInvalidSessionIdForNativeFileSessionHandler()
         $this->assertTrue($started);
         $this->assertSame('&~[', session_id());
     }
+
+    public function testSaveHandlesNullSessionGracefully()
+    {
+        $storage = $this->getStorage();
+        $_SESSION = null;
+        $storage->save();
+
+        $this->addToAssertionCount(1);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ public function save()`
`256`	`256`	`unset($_SESSION[$key]);`
`257`	`257`	`}`
`258`	`258`	`}`
`259`		`- if ([$key = $this->metadataBag->getStorageKey()] === array_keys($_SESSION)) {`
	`259`	`+ if ($_SESSION && [$key = $this->metadataBag->getStorageKey()] === array_keys($_SESSION)) {`
`260`	`260`	`unset($_SESSION[$key]);`
`261`	`261`	`}`
`262`	`262`
Original file line number	Diff line number	Diff line change
`@@ -321,4 +321,13 @@ public function testRegenerateInvalidSessionIdForNativeFileSessionHandler()`
`321`	`321`	`$this->assertTrue($started);`
`322`	`322`	`$this->assertSame('&~[', session_id());`
`323`	`323`	`}`
	`324`	`+`
	`325`	`+ public function testSaveHandlesNullSessionGracefully()`
	`326`	`+ {`
	`327`	`+ $storage = $this->getStorage();`
	`328`	`+ $_SESSION = null;`
	`329`	`+ $storage->save();`
	`330`	`+`
	`331`	`+ $this->addToAssertionCount(1);`
	`332`	`+ }`
`324`	`333`	`}`