throw when invalid

dunglas · dunglas · commit 262906b505ed · 2018-07-13T14:04:59.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php b/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php
@@ -38,9 +38,11 @@ public function __construct($entityManager)
     {
         if ($entityManager instanceof EntityManagerInterface) {
             $this->entityManager = $entityManager;
-        } else {
+        } elseif ($entityManager instanceof ClassMetadataFactory) {
             @trigger_error(sprintf('Injecting an instance of "%s" in "%s" is deprecated since Symfony 4.2, inject an instance of "%s" instead.', ClassMetadataFactory::class, __CLASS__, EntityManagerInterface::class), E_USER_DEPRECATED);
             $this->classMetadataFactory = $entityManager;
+        } else {
+            throw new \InvalidArgumentException(sprintf('$entityManager must be an instance of "%s", "%s" given.', EntityManagerInterface::class, \is_object($entityManager) ? \get_class($entityManager) : \gettype($entityManager)));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ - 8B89 38,9 +38,11 @@ public function __construct($entityManager)`
`38`	`38`	`{`
`39`	`39`	`if ($entityManager instanceof EntityManagerInterface) {`
`40`	`40`	`$this->entityManager = $entityManager;`
`41`		`- } else {`
	`41`	`+ } elseif ($entityManager instanceof ClassMetadataFactory) {`
`42`	`42`	`@trigger_error(sprintf('Injecting an instance of "%s" in "%s" is deprecated since Symfony 4.2, inject an instance of "%s" instead.', ClassMetadataFactory::class, __CLASS__, EntityManagerInterface::class), E_USER_DEPRECATED);`
`43`	`43`	`$this->classMetadataFactory = $entityManager;`
	`44`	`+ } else {`
	`45`	`+ throw new \InvalidArgumentException(sprintf('$entityManager must be an instance of "%s", "%s" given.', EntityManagerInterface::class, \is_object($entityManager) ? \get_class($entityManager) : \gettype($entityManager)));`
`44`	`46`	`}`
`45`	`47`	`}`
`46`	`48`