minor #28830 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' (kevin-biig)

fabpot · fabpot · commit 261c0dea910a · 2018-10-12T05:58:47.000-07:00
This PR was merged into the 4.2-dev branch. Discussion ---------- 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' A little fix of my [previous PR](#28815) This PR changes the constant visibility of the `yml` format as private. Because as @stof [mentionned](#28815 (comment)) `yml` isn't a format, so the constant shoudn't be public. Otherwise, this will be confusing while using autocomplete, you see two formats. The user can ask himself if there is a difference between `yaml` / `yml`. No need of that :) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | License | MIT | Doc PR | Commits ------- 674b359 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' class
diff --git a/src/Symfony/Component/Serializer/Encoder/YamlEncoder.php b/src/Symfony/Component/Serializer/Encoder/YamlEncoder.php
@@ -23,7 +23,7 @@
 class YamlEncoder implements EncoderInterface, DecoderInterface
 {
     const FORMAT = 'yaml';
-    const ALTERNATIVE_FORMAT = 'yml';
+    private const ALTERNATIVE_FORMAT = 'yml';
 
     private $dumper;
     private $parser;

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`class YamlEncoder implements EncoderInterface, DecoderInterface`
`24`	`24`	`{`
`25`	`25`	`const FORMAT = 'yaml';`
`26`		`- const ALTERNATIVE_FORMAT = 'yml';`
	`26`	`+ private const ALTERNATIVE_FORMAT = 'yml';`
`27`	`27`
`28`	`28`	`private $dumper;`
`29`	`29`	`private $parser;`