Dont lock tables or start transactions

Nyholm · Nyholm · commit 26061a131d97 · 2021-03-05T13:14:19.000+01:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/PostgreSqlConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/PostgreSqlConnectionTest.php
@@ -51,16 +51,10 @@ public function testGetExtraSetupSql()
         $table->addOption('_symfony_messenger_table_name', 'queue_table');
         $sql = implode("\n", $connection->getExtraSetupSqlForTable($table));
 
-        /*
-         * We need to start a transaction for the following commands to work properly:
-         * doctrine:schema:create
-         * messenger:setup-transports
-         * doctrine:migrations:diff and doctrine:migrations:migrate
-         */
-        $this->assertStringContainsString('BEGIN;', $sql);
         $this->assertStringContainsString('CREATE TRIGGER', $sql);
 
-        // We MUST NOT commit, that will mess with the PDO in PHP 8
+        // We MUST NOT use transaction, that will mess with the PDO in PHP 8
+        $this->assertStringNotContainsString('BEGIN;', $sql);
         $this->assertStringNotContainsString('COMMIT;', $sql);
     }
 
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php
@@ -109,8 +109,6 @@ public function getExtraSetupSqlForTable(Table $createdTable): array
     private function getTriggerSql(): array
     {
         return [
-            'BEGIN;',
-            sprintf('LOCK TABLE %s;', $this->configuration['table_name']),
             // create trigger function
             sprintf(<<<'SQL'
 CREATE OR REPLACE FUNCTION notify_%1$s() RETURNS TRIGGER AS $$

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,6 @@ public function getExtraSetupSqlForTable(Table $createdTable): array`
`109`	`109`	`private function getTriggerSql(): array`
`110`	`110`	`{`
`111`	`111`	`return [`
`112`		`- 'BEGIN;',`
`113`		`- sprintf('LOCK TABLE %s;', $this->configuration['table_name']),`
`114`	`112`	`// create trigger function`
`115`	`113`	`sprintf(<<<'SQL'`
`116`	`114`	`CREATE OR REPLACE FUNCTION notify_%1$s() RETURNS TRIGGER AS $$`