8000 [Tests] Replace `setUp()`/`tearDown()` with `before()`/`after()` · symfony/symfony@24c38da · GitHub
[go: up one dir, main page]
Skip to content

Commit 24c38da

Browse files
phansysphansys
committed
[Tests] Replace setUp()/tearDown() with before()/after() 
1 parent 950306a commit 24c38da

File tree

321 files changed

+1763
-445
lines changed
  • Messenger
  • Validator/Constraints
  • PhpUnit/Tests
  • ProxyManager/Tests/LazyProxy
  • Twig/Tests
  • Bundle
  • Component

    • Some content is hidden

    Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

    321 files changed

    +1763
    -445
    lines changed

    ‎src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -20,7 +20,10 @@ class ContainerAwareEventManagerTest extends TestCase
    2020
    private $container;
    2121
    private $evm;
    2222

    23-
    protected function setUp()
    23+
    /**
    24+
    * @before
    25+
    */
    26+
    protected function before(): void
    2427
    {
    2528
    $this->container = new Container();
    2629
    $this->evm = new ContainerAwareEventManager($this->container);

    ‎src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/DoctrineExtensionTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -26,7 +26,10 @@ class DoctrineExtensionTest extends TestCase
    2626
    */
    2727
    private $extension;
    2828

    29-
    protected function setUp()
    29+
    /**
    30+
    * @before
    31+
    */
    32+
    protected function before(): void
    3033
    {
    3134
    parent::setUp();
    3235

    ‎src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/DoctrineChoiceLoaderTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -72,7 +72,10 @@ class DoctrineChoiceLoaderTest extends TestCase
    7272
    */
    7373
    private $obj3;
    7474

    75-
    protected function setUp()
    75+
    /**
    76+
    * @before
    77+
    */
    78+
    protected function before(): void
    7679
    {
    7780
    $this->factory = $this->getMockBuilder('Symfony\Component\Form\ChoiceList\Factory\ChoiceListFactoryInterface')->getMock();
    7881
    $this->om = $this->getMockBuilder('Doctrine\Common\Persistence\ObjectManager')->getMock();

    ‎src/Symfony/Bridge/Doctrine/Tests/Form/DataTransformer/CollectionToArrayTransformerTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -25,7 +25,10 @@ class CollectionToArrayTransformerTest extends TestCase
    2525
    */
    2626
    private $transformer;
    2727

    28-
    protected function setUp()
    28+
    /**
    29+
    * @before
    30+
    */
    31+
    protected function before(): void
    2932
    {
    3033
    $this->transformer = new CollectionToArrayTransformer();
    3134
    }

    ‎src/Symfony/Bridge/Doctrine/Tests/Form/EventListener/MergeDoctrineCollectionListenerTest.php

    Lines changed: 8 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -28,7 +28,10 @@ class MergeDoctrineCollectionListenerTest extends TestCase
    2828
    private $factory;
    2929
    private $form;
    3030

    31-
    protected function setUp()
    31+
    /**
    32+
    * @before
    33+
    */
    34+
    protected function before(): void
    3235
    {
    3336
    $this->collection = new ArrayCollection(['test']);
    3437
    $this->dispatcher = new EventDispatcher();
    @@ -37,7 +40,10 @@ protected function setUp()
    3740
    ->getForm();
    3841
    }
    3942

    40-
    protected function tearDown()
    43+
    /**
    44+
    * @after
    45+
    */
    46+
    protected function after(): void
    4147
    {
    4248
    $this->collection = null;
    4349
    $this->dispatcher = null;

    ‎src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypePerformanceTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -50,7 +50,10 @@ protected function getExtensions()
    5050
    ];
    5151
    }
    5252

    53-
    protected function setUp()
    53+
    /**
    54+
    * @before
    55+
    */
    56+
    protected function before(): void
    5457
    {
    5558
    $this->em = DoctrineTestHelper::createTestEntityManager();
    5659

    ‎src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php

    Lines changed: 8 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -59,7 +59,10 @@ class EntityTypeTest extends BaseTypeTest
    5959

    6060
    protected static $supportedFeatureSetVersion = 304;
    6161

    62-
    protected function setUp()
    62+
    /**
    63+
    * @before
    64+
    */
    65+
    protected function before(): void
    6366
    {
    6467
    $this->em = DoctrineTestHelper::createTestEntityManager();
    6568
    $this->emRegistry = $this->createRegistryMock('default', $this->em);
    @@ -89,7 +92,10 @@ protected function setUp()
    8992
    }
    9093
    }
    9194

    92-
    protected function tearDown()
    95+
    /**
    96+
    * @after
    97+
    */
    98+
    protected function after(): void
    9399
    {
    94100
    parent::tearDown();
    95101

    ‎src/Symfony/Bridge/Doctrine/Tests/Messenger/DoctrineCloseConnectionMiddlewareTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -27,7 +27,10 @@ class DoctrineCloseConnectionMiddlewareTest extends MiddlewareTestCase
    2727
    private $middleware;
    2828
    private $entityManagerName = 'default';
    2929

    30-
    protected function setUp()
    30+
    /**
    31+
    * @before
    32+
    */
    33+
    protected function before(): void
    3134
    {
    3235
    $this->connection = $this->createMock(Connection::class);
    3336

    ‎src/Symfony/Bridge/Doctrine/Tests/Messenger/DoctrinePingConnectionMiddlewareTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -27,7 +27,10 @@ class DoctrinePingConnectionMiddlewareTest extends MiddlewareTestCase
    2727
    private $middleware;
    2828
    private $entityManagerName = 'default';
    2929

    30-
    protected function setUp()
    30+
    /**
    31+
    * @before
    32+
    */
    33+
    protected function before(): void
    3134
    {
    3235
    $this->connection = $this->createMock(Connection::class);
    3336

    ‎src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php

    Lines changed: 4 additions & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -58,7 +58,10 @@ class UniqueEntityValidatorTest extends ConstraintValidatorTestCase
    5858

    5959
    protected $repositoryFactory;
    6060

    61-
    protected function setUp()
    61+
    /**
    62+
    * @before
    63+
    */
    64+
    protected function before(): void
    6265
    {
    6366
    $this->repositoryFactory = new TestRepositoryFactory();
    6467

    0 commit comments

    Comments
     (0)
    0