Add type hints

greg0ire · greg0ire · commit 2403702516b3 · 2018-04-21T00:28:10.000+02:00
This makes those classes compatible with phpunit 7. Fixes #26931
diff --git a/src/Symfony/Bridge/PhpUnit/TextUI/Command.php b/src/Symfony/Bridge/PhpUnit/TextUI/Command.php
@@ -12,6 +12,7 @@
 namespace Symfony\Bridge\PhpUnit\TextUI;
 
 use PHPUnit\TextUI\Command as BaseCommand;
+use PHPUnit\TextUI\TestRunner as BaseRunner;
 
 if (class_exists('PHPUnit_Runner_Version') && version_compare(\PHPUnit_Runner_Version::id(), '6.0.0', '<')) {
     class_alias('Symfony\Bridge\PhpUnit\Legacy\Command', 'Symfony\Bridge\PhpUnit\TextUI\Command');
@@ -26,7 +27,7 @@ class Command extends BaseCommand
         /**
          * {@inheritdoc}
          */
-        protected function createRunner()
+        protected function createRunner(): BaseRunner
         {
             return new TestRunner($this->arguments['loader']);
         }
diff --git a/src/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php b/src/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php
@@ -27,11 +27,11 @@ class TestRunner extends BaseRunner
         /**
          * {@inheritdoc}
          */
-        protected function handleConfiguration(array &$arguments)
+        protected function handleConfiguration(array &$arguments): void
         {
             $listener = new SymfonyTestsListener();
 
-            $result = parent::handleConfiguration($arguments);
+            parent::handleConfiguration($arguments);
 
             $arguments['listeners'] = isset($arguments['listeners']) ? $arguments['listeners'] : array();
 
@@ -48,8 +48,6 @@ protected function handleConfiguration(array &$arguments)
             if (!$registeredLocally) {
                 $arguments['listeners'][] = $listener;
             }
-
-            return $result;
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\Bridge\PhpUnit\TextUI;`
`13`	`13`
`14`	`14`	`use PHPUnit\TextUI\Command as BaseCommand;`
	`15`	`+use PHPUnit\TextUI\TestRunner as BaseRunner;`
`15`	`16`
`16`	`17`	`if (class_exists('PHPUnit_Runner_Version') && version_compare(\PHPUnit_Runner_Version::id(), '6.0.0', '<')) {`
`17`	`18`	`class_alias('Symfony\Bridge\PhpUnit\Legacy\Command', 'Symfony\Bridge\PhpUnit\TextUI\Command');`
`@@ -26,7 +27,7 @@ class Command extends BaseCommand`
`26`	`27`	`/**`
`27`	`28`	`* {@inheritdoc}`
`28`	`29`	`*/`
`29`		`- protected function createRunner()`
	`30`	`+ protected function createRunner(): BaseRunner`
`30`	`31`	`{`
`31`	`32`	`return new TestRunner($this->arguments['loader']);`
`32`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,11 @@ class TestRunner extends BaseRunner`
`27`	`27`	`/**`
`28`	`28`	`* {@inheritdoc}`
`29`	`29`	`*/`
`30`		`- protected function handleConfiguration(array &$arguments)`
	`30`	`+ protected function handleConfiguration(array &$arguments): void`
`31`	`31`	`{`
`32`	`32`	`$listener = new SymfonyTestsListener();`
`33`	`33`
`34`		`- $result = parent::handleConfiguration($arguments);`
	`34`	`+ parent::handleConfiguration($arguments);`
`35`	`35`
`36`	`36`	`$arguments['listeners'] = isset($arguments['listeners']) ? $arguments['listeners'] : array();`
`37`	`37`
`@@ -48,8 +48,6 @@ protected function handleConfiguration(array &$arguments)`
`48`	`48`	`if (!$registeredLocally) {`
`49`	`49`	`$arguments['listeners'][] = $listener;`
`50`	`50`	`}`
`51`		`-`
`52`		`- return $result;`
`53`	`51`	`}`
`54`	`52`	`}`
`55`	`53`	`}`