bug #29393 [DI] fix edge case in InlineServiceDefinitionsPass (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 21db5881575a · 2018-12-01T09:16:32.000+01:00
This PR was merged into the 4.1 branch. Discussion ---------- [DI] fix edge case in InlineServiceDefinitionsPass | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Looks like this can happen - dunno how https://stackoverflow.com/questions/53558247/autowire-services-test-yaml-there-is-no-node-with-id-service-a Commits ------- 8bd2bbf [DI] fix edge case in InlineServiceDefinitionsPass
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -92,6 +92,10 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe
             return false;
         }
 
+        if (!$graph->hasNode($id)) {
+            return true;
+        }
+
         if (!$definition->isShared()) {
             foreach ($graph->getNode($id)->getInEdges() as $edge) {
                 if ($edge->isWeak()) {
@@ -106,10 +110,6 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe
             return false;
         }
 
-        if (!$graph->hasNode($id)) {
-            return true;
-        }
-
         if ($this->currentId == $id) {
             return false;
         }

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,10 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe`
`92`	`92`	`return false;`
`93`	`93`	`}`
`94`	`94`
	`95`	`+ if (!$graph->hasNode($id)) {`
	`96`	`+ return true;`
	`97`	`+ }`
	`98`	`+`
`95`	`99`	`if (!$definition->isShared()) {`
`96`	`100`	`foreach ($graph->getNode($id)->getInEdges() as $edge) {`
`97`	`101`	`if ($edge->isWeak()) {`
`@@ -106,10 +110,6 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe`
`106`	`110`	`return false;`
`107`	`111`	`}`
`108`	`112`
`109`		`- if (!$graph->hasNode($id)) {`
`110`		`- return true;`
`111`		`- }`
`112`		`-`
`113`	`113`	`if ($this->currentId == $id) {`
`114`	`114`	`return false;`
`115`	`115`	`}`