minor #59738 Make data providers static (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 20cdfab6dacb · 2025-02-10T09:57:22.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- Make data providers static | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Non-static data providers are deprecated. Fabbot also raised two formatting problems in the same files on anonymous class instanciation, so this PR also fixes them. Commits ------- 8bfa9a5 Make data providers static
diff --git a/src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
@@ -317,7 +317,7 @@ public function testWithEmbed(BlueskyOptions $blueskyOptions, string $expectedJs
         $this->assertSame('103254962155278888', $result->getMessageId());
     }
 
-    public function sendMessageWithEmbedDataProvider(): iterable
+    public static function sendMessageWithEmbedDataProvider(): iterable
     {
         yield 'With media' => [
             'options' => (new BlueskyOptions())->attachMedia(new File(__DIR__.'/fixtures.gif'), 'A fixture'),
diff --git a/src/Symfony/Component/PropertyInfo/Tests/PropertyInfoCacheExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/PropertyInfoCacheExtractorTest.php
@@ -90,7 +90,7 @@ public function testIsInitializable()
      */
     public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)
     {
-        $propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class() implements PropertyInfoExtractorInterface {
+        $propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class implements PropertyInfoExtractorInterface {
             private PropertyTypeExtractorInterface $propertyTypeExtractor;
 
             public function __construct()
@@ -136,7 +136,7 @@ public function getProperties(string $class, array $context = []): ?array
         }
     }
 
-    public function provideNestedExtractorWithoutGetTypeImplementationData()
+    public static function provideNestedExtractorWithoutGetTypeImplementationData()
     {
         yield ['bar', Type::string()];
         yield ['baz', Type::int()];
diff --git a/src/Symfony/Component/PropertyInfo/Tests/PropertyInfoExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/PropertyInfoExtractorTest.php
@@ -30,7 +30,7 @@ class PropertyInfoExtractorTest extends AbstractPropertyInfoExtractorTest
      */
     public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)
     {
-        $propertyInfoExtractor = new PropertyInfoExtractor([], [new class() implements PropertyTypeExtractorInterface {
+        $propertyInfoExtractor = new PropertyInfoExtractor([], [new class implements PropertyTypeExtractorInterface {
             private PropertyTypeExtractorInterface $propertyTypeExtractor;
 
             public function __construct()
@@ -51,7 +51,7 @@ public function getTypes(string $class, string $property, array $context = []):
         }
     }
 
-    public function provideNestedExtractorWithoutGetTypeImplementationData()
+    public static function provideNestedExtractorWithoutGetTypeImplementationData()
     {
         yield ['bar', Type::string()];
         yield ['baz', Type::int()];

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ public function testWithEmbed(BlueskyOptions $blueskyOptions, string $expectedJs`
`317`	`317`	`$this->assertSame('103254962155278888', $result->getMessageId());`
`318`	`318`	`}`
`319`	`319`
`320`		`- public function sendMessageWithEmbedDataProvider(): iterable`
	`320`	`+ public static function sendMessageWithEmbedDataProvider(): iterable`
`321`	`321`	`{`
`322`	`322`	`yield 'With media' => [`
`323`	`323`	`'options' => (new BlueskyOptions())->attachMedia(new File(__DIR__.'/fixtures.gif'), 'A fixture'),`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function testIsInitializable()`
`90`	`90`	`*/`
`91`	`91`	`public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)`
`92`	`92`	`{`
`93`		`- $propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class() implements PropertyInfoExtractorInterface {`
	`93`	`+ $propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class implements PropertyInfoExtractorInterface {`
`94`	`94`	`private PropertyTypeExtractorInterface $propertyTypeExtractor;`
`95`	`95`
`96`	`96`	`public function __construct()`
`@@ -136,7 +136,7 @@ public function getProperties(string $class, array $context = []): ?array`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`		`- public function provideNestedExtractorWithoutGetTypeImplementationData()`
	`139`	`+ public static function provideNestedExtractorWithoutGetTypeImplementationData()`
`140`	`140`	`{`
`141`	`141`	`yield ['bar', Type::string()];`
`142`	`142`	`yield ['baz', Type::int()];`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class PropertyInfoExtractorTest extends AbstractPropertyInfoExtractorTest`
`30`	`30`	`*/`
`31`	`31`	`public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)`
`32`	`32`	`{`
`33`		`- $propertyInfoExtractor = new PropertyInfoExtractor([], [new class() implements PropertyTypeExtractorInterface {`
	`33`	`+ $propertyInfoExtractor = new PropertyInfoExtractor([], [new class implements PropertyTypeExtractorInterface {`
`34`	`34`	`private PropertyTypeExtractorInterface $propertyTypeExtractor;`
`35`	`35`
`36`	`36`	`public function __construct()`
`@@ -51,7 +51,7 @@ public function getTypes(string $class, string $property, array $context = []):`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function provideNestedExtractorWithoutGetTypeImplementationData()`
	`54`	`+ public static function provideNestedExtractorWithoutGetTypeImplementationData()`
`55`	`55`	`{`
`56`	`56`	`yield ['bar', Type::string()];`
`57`	`57`	`yield ['baz', Type::int()];`